Re: [PATCH 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-17 Thread Cédric Le Goater
On 1/17/24 22:11, Matthew Rosato wrote: On 1/17/24 10:19 AM, Matthew Rosato wrote: On 1/17/24 6:01 AM, Cédric Le Goater wrote: Adding Alex, On 1/16/24 23:31, Matthew Rosato wrote: ISM devices are sensitive to manipulation of the IOMMU, so the ISM device needs to be reset before the vfio-pci

Re: [PATCH 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-17 Thread Matthew Rosato
On 1/17/24 10:19 AM, Matthew Rosato wrote: > On 1/17/24 6:01 AM, Cédric Le Goater wrote: >> Adding Alex, >> >> On 1/16/24 23:31, Matthew Rosato wrote: >>> ISM devices are sensitive to manipulation of the IOMMU, so the ISM device >>> needs to be reset before the vfio-pci device is reset (triggering

Re: [PATCH 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-17 Thread Matthew Rosato
On 1/17/24 6:01 AM, Cédric Le Goater wrote: > Adding Alex, > > On 1/16/24 23:31, Matthew Rosato wrote: >> ISM devices are sensitive to manipulation of the IOMMU, so the ISM device >> needs to be reset before the vfio-pci device is reset (triggering a full >> UNMAP).  In order to ensure this

Re: [PATCH 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-17 Thread Matthew Rosato
On 1/16/24 10:01 PM, Eric Farman wrote: > On Tue, 2024-01-16 at 17:31 -0500, Matthew Rosato wrote: >>   >> +void s390_pci_ism_reset(void) >> +{ >> +    S390pciState *s = s390_get_phb(); >> + >> +    S390PCIBusDevice *pbdev, *next; >> + >> +    /* Trigger reset event for each passthrough ISM

Re: [PATCH 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-17 Thread Cédric Le Goater
Adding Alex, On 1/16/24 23:31, Matthew Rosato wrote: ISM devices are sensitive to manipulation of the IOMMU, so the ISM device needs to be reset before the vfio-pci device is reset (triggering a full UNMAP). In order to ensure this occurs, trigger ISM device resets from subsystem_reset before

Re: [PATCH 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-16 Thread Eric Farman
On Tue, 2024-01-16 at 17:31 -0500, Matthew Rosato wrote: > ISM devices are sensitive to manipulation of the IOMMU, so the ISM > device > needs to be reset before the vfio-pci device is reset (triggering a > full > UNMAP).  In order to ensure this occurs, trigger ISM device resets > from >

[PATCH 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-16 Thread Matthew Rosato
ISM devices are sensitive to manipulation of the IOMMU, so the ISM device needs to be reset before the vfio-pci device is reset (triggering a full UNMAP). In order to ensure this occurs, trigger ISM device resets from subsystem_reset before triggering the PCI bus reset (which will also trigger