Re: [PATCH 3/4] semihosting: Check for errors on SET_ARG()

2022-07-24 Thread Richard Henderson
On 7/19/22 17:41, Peter Maydell wrote: The SET_ARG() macro returns an error indication; we check this in the TARGET_SYS_GET_CMDLINE case but not when we use it in implementing TARGET_SYS_ELAPSED. Check for and handle the errors via the do_fault codepath, and update the comment documenting the SE

[PATCH 3/4] semihosting: Check for errors on SET_ARG()

2022-07-19 Thread Peter Maydell
The SET_ARG() macro returns an error indication; we check this in the TARGET_SYS_GET_CMDLINE case but not when we use it in implementing TARGET_SYS_ELAPSED. Check for and handle the errors via the do_fault codepath, and update the comment documenting the SET_ARG() and GET_ARG() macros to note how