Re: [PATCH 3/4] virtio-ccw: move device type declarations to .c files

2022-03-31 Thread Halil Pasic
On Mon, 28 Mar 2022 16:30:18 +0200 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Just curious: is device type declarations for leaf device types should be private a best practice in QEMU? > --- > hw/s390x/s390-virtio-ccw.c| 1 + > hw/s390x/vhost-scsi-ccw.c | 9 +++ >

Re: [PATCH 3/4] virtio-ccw: move device type declarations to .c files

2022-03-30 Thread Thomas Huth
On 28/03/2022 16.30, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- hw/s390x/s390-virtio-ccw.c| 1 + hw/s390x/vhost-scsi-ccw.c | 9 +++ hw/s390x/vhost-vsock-ccw.c| 9 +++ hw/s390x/virtio-ccw-9p.c | 9 +++ hw/s390x/virtio-ccw-balloon.c | 9 +++

[PATCH 3/4] virtio-ccw: move device type declarations to .c files

2022-03-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/s390x/s390-virtio-ccw.c| 1 + hw/s390x/vhost-scsi-ccw.c | 9 +++ hw/s390x/vhost-vsock-ccw.c| 9 +++ hw/s390x/virtio-ccw-9p.c | 9 +++ hw/s390x/virtio-ccw-balloon.c | 9 +++ hw/s390x/virtio-ccw-blk.c | 9 +++