Re: [PATCH 3/5] meson: subprojects: replace submodules with wrap files

2023-05-30 Thread Daniel P . Berrangé
On Tue, May 30, 2023 at 02:51:07PM +0200, Paolo Bonzini wrote: > On Tue, May 30, 2023 at 2:24 PM Daniel P. Berrangé > wrote: > > > +if test -e "$source_path/.git"; then > > > +echo "--disable-download specified but subprojects were not" > > > +echo "checked out. Please

Re: [PATCH 3/5] meson: subprojects: replace submodules with wrap files

2023-05-30 Thread Paolo Bonzini
On Tue, May 30, 2023 at 2:24 PM Daniel P. Berrangé wrote: > > +if test -e "$source_path/.git"; then > > +echo "--disable-download specified but subprojects were not" > > +echo "checked out. Please download subprojects." > > Building from tarball will be ok as we bundle

Re: [PATCH 3/5] meson: subprojects: replace submodules with wrap files

2023-05-30 Thread Daniel P . Berrangé
On Sat, May 27, 2023 at 11:28:49AM +0200, Paolo Bonzini wrote: > Compared to submodules, .wrap files have several advantages: > > * option parsing and downloading is delegated to meson > > * the commit is stored in a text file instead of a magic entry in the > git tree object > > * we could

[PATCH 3/5] meson: subprojects: replace submodules with wrap files

2023-05-27 Thread Paolo Bonzini
Compared to submodules, .wrap files have several advantages: * option parsing and downloading is delegated to meson * the commit is stored in a text file instead of a magic entry in the git tree object * we could stop shipping external dependencies that are only used as a fallback, but not