Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-19 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Oct 18, 2023 at 02:02:08PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote: >> >> On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote: >> >> > > x- seems

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-19 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > Using x- for events makes sense to me; the semantics of events can be > quite subtle; often you don't find out how broken they are until you > wire them through libvirt and up the stack; so it's not impossible > you might need to change it - but then without

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-19 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 18.10.23 15:02, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >>> On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote: On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote: >> x- seems safer for

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-18 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Oct 18, 2023 at 02:02:08PM +0200, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > > > > > On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote: > > >> On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-18 Thread Vladimir Sementsov-Ogievskiy
On 18.10.23 15:02, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote: On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote: x- seems safer for management tool that doesn't know about "unstable" properties..

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-18 Thread Daniel P . Berrangé
On Wed, Oct 18, 2023 at 02:02:08PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote: > >> On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote: > >> > > x- seems safer for management tool that

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-18 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote: >> On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote: >> > > x- seems safer for management tool that doesn't know about "unstable" >> > > properties.. >> > >> > Easy, traditional,

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-18 Thread Daniel P . Berrangé
On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote: > On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote: > > > x- seems safer for management tool that doesn't know about "unstable" > > > properties.. > > > > Easy, traditional, and unreliable :) > > > > But on the

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-18 Thread Michael S. Tsirkin
On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote: > > x- seems safer for management tool that doesn't know about "unstable" > > properties.. > > Easy, traditional, and unreliable :) > > But on the other hand, changing from x- to no-prefix is already done when > > the feature

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-18 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 18.10.23 09:47, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> On 17.10.23 18:00, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > Send a new event when guest reads virtio-pci config after >

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-18 Thread Vladimir Sementsov-Ogievskiy
On 18.10.23 09:47, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: On 17.10.23 18:00, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Send a new event when guest reads virtio-pci config after virtio_notify_config() call. That's useful to check that guest

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-18 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 17.10.23 18:00, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Send a new event when guest reads virtio-pci config after >>> virtio_notify_config() call. >>> >>> That's useful to check that guest fetched modified config, for

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
On 17.10.23 18:00, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Send a new event when guest reads virtio-pci config after virtio_notify_config() call. That's useful to check that guest fetched modified config, for example after resizing disk backend. Signed-off-by: Vladimir

Re: [PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-17 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Send a new event when guest reads virtio-pci config after > virtio_notify_config() call. > > That's useful to check that guest fetched modified config, for example > after resizing disk backend. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

[PATCH 4/4] qapi: introduce CONFIG_READ event

2023-10-06 Thread Vladimir Sementsov-Ogievskiy
Send a new event when guest reads virtio-pci config after virtio_notify_config() call. That's useful to check that guest fetched modified config, for example after resizing disk backend. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/virtio-pci.c | 9 +