Re: [PATCH 4/5] [RISCV_PM] Add address masking functions required for RISC-V Pointer Masking extension

2020-10-15 Thread Alexey Baturo
Hi folks, I've sent new v2 patches where, I hope, I managed to address all the comments and suggestions that were provided. Thanks! ср, 14 окт. 2020 г. в 23:10, Alexey Baturo : > > I suggest adding a stub version of this function to patch 5, and then > swap patch 4 and patch 5. > Thanks, will

Re: [PATCH 4/5] [RISCV_PM] Add address masking functions required for RISC-V Pointer Masking extension

2020-10-14 Thread Alexey Baturo
> I suggest adding a stub version of this function to patch 5, and then swap patch 4 and patch 5. Thanks, will do. >This bakes in values from ENV without adding any way to verify that those values are still current. If I correctly get your idea, you're talking about the situation, when

Re: [PATCH 4/5] [RISCV_PM] Add address masking functions required for RISC-V Pointer Masking extension

2020-10-14 Thread Richard Henderson
On 10/14/20 10:01 AM, Alexey Baturo wrote: > +static TCGv_i64 apply_pointer_masking(DisasContext *s, TCGv_i64 addr) > +{ > +gen_pm_adjust_address(s, addr, addr); > +return addr; > +} This function is unused in this patch, which means the series as a whole is non-bisectable. Rather than

[PATCH 4/5] [RISCV_PM] Add address masking functions required for RISC-V Pointer Masking extension

2020-10-14 Thread Alexey Baturo
From: Anatoly Parshintsev Signed-off-by: Anatoly Parshintsev --- target/riscv/translate.c | 65 1 file changed, 65 insertions(+) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 79dca2291b..338a967e0c 100644 ---