Re: [PATCH 4/5] chardev/char.c: Always pass id to chardev_new

2021-03-22 Thread Li Zhang
Looks good to me. I have tested this series, it works well. Tested-by: Li Zhang Thanks Li On Mon, Mar 22, 2021 at 12:35 AM Lukas Straub wrote: > Always pass the id to chardev_new, since it is needed to register > the yank instance for the chardev. Also, after checking that > nothing calls char

Re: [PATCH 4/5] chardev/char.c: Always pass id to chardev_new

2021-03-22 Thread Marc-André Lureau
On Mon, Mar 22, 2021 at 3:31 AM Lukas Straub wrote: > Always pass the id to chardev_new, since it is needed to register > the yank instance for the chardev. Also, after checking that > nothing calls chardev_new with id=NULL, assert() that id!=NULL. > > This fixes a crash when using chardev-change

[PATCH 4/5] chardev/char.c: Always pass id to chardev_new

2021-03-21 Thread Lukas Straub
Always pass the id to chardev_new, since it is needed to register the yank instance for the chardev. Also, after checking that nothing calls chardev_new with id=NULL, assert() that id!=NULL. This fixes a crash when using chardev-change to change a chardev to chardev-socket, which attempts to regis