Re: [PATCH 4/5] migration: Provide QMP access to downtime stats

2023-10-06 Thread Peter Xu
On Fri, Oct 06, 2023 at 12:37:15PM +0100, Joao Martins wrote: > I added the statistics mainly for observability (e.g. you would grep in the > libvirt logs for a non developer and they can understand how downtime is > explained). I wasn't specifically thinking about management app using this, >

Re: [PATCH 4/5] migration: Provide QMP access to downtime stats

2023-10-06 Thread Joao Martins
On 04/10/2023 18:10, Peter Xu wrote: > Hi, Joao, > > On Tue, Sep 26, 2023 at 05:18:40PM +0100, Joao Martins wrote: >> Deliver the downtime breakdown also via `query-migrate` >> to allow users to understand what their downtime value >> represents. > > I agree downtime is an area we definitely

Re: [PATCH 4/5] migration: Provide QMP access to downtime stats

2023-10-04 Thread Peter Xu
Hi, Joao, On Tue, Sep 26, 2023 at 05:18:40PM +0100, Joao Martins wrote: > Deliver the downtime breakdown also via `query-migrate` > to allow users to understand what their downtime value > represents. I agree downtime is an area we definitely need to improve.. however do we need to make it part

[PATCH 4/5] migration: Provide QMP access to downtime stats

2023-09-26 Thread Joao Martins
Deliver the downtime breakdown also via `query-migrate` to allow users to understand what their downtime value represents. Signed-off-by: Joao Martins --- qapi/migration.json | 22 ++ migration/migration.c | 14 ++ 2 files changed, 36 insertions(+) diff --git