Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-24 Thread Damien Hedde
On 2/23/22 19:20, John Snow wrote: On Wed, Feb 23, 2022 at 12:09 PM Damien Hedde wrote: On 2/23/22 17:18, John Snow wrote: On Wed, Feb 23, 2022 at 10:44 AM Daniel P. Berrangé wrote: On Wed, Feb 23, 2022 at 10:41:11AM -0500, John Snow wrote: On Wed, Feb 23, 2022 at 10:27 AM Daniel P.

Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-23 Thread John Snow
On Wed, Feb 23, 2022 at 12:09 PM Damien Hedde wrote: > > > > On 2/23/22 17:18, John Snow wrote: > > On Wed, Feb 23, 2022 at 10:44 AM Daniel P. Berrangé > > wrote: > >> > >> On Wed, Feb 23, 2022 at 10:41:11AM -0500, John Snow wrote: > >>> On Wed, Feb 23, 2022 at 10:27 AM Daniel P. Berrangé >

Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-23 Thread Daniel P . Berrangé
On Wed, Feb 23, 2022 at 11:18:26AM -0500, John Snow wrote: > On Wed, Feb 23, 2022 at 10:44 AM Daniel P. Berrangé > wrote: > > > > On Wed, Feb 23, 2022 at 10:41:11AM -0500, John Snow wrote: > > > On Wed, Feb 23, 2022 at 10:27 AM Daniel P. Berrangé > > > wrote: > > > > > > > > On Wed, Feb 23,

Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-23 Thread Damien Hedde
On 2/23/22 17:18, John Snow wrote: On Wed, Feb 23, 2022 at 10:44 AM Daniel P. Berrangé wrote: On Wed, Feb 23, 2022 at 10:41:11AM -0500, John Snow wrote: On Wed, Feb 23, 2022 at 10:27 AM Daniel P. Berrangé wrote: On Wed, Feb 23, 2022 at 10:22:11AM -0500, John Snow wrote: On Mon, Feb

Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-23 Thread Damien Hedde
On 2/23/22 17:43, Damien Hedde wrote: On 2/23/22 16:44, Daniel P. Berrangé wrote: On Wed, Feb 23, 2022 at 10:41:11AM -0500, John Snow wrote: On Wed, Feb 23, 2022 at 10:27 AM Daniel P. Berrangé wrote: On Wed, Feb 23, 2022 at 10:22:11AM -0500, John Snow wrote: On Mon, Feb 21, 2022 at

Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-23 Thread Damien Hedde
On 2/23/22 16:44, Daniel P. Berrangé wrote: On Wed, Feb 23, 2022 at 10:41:11AM -0500, John Snow wrote: On Wed, Feb 23, 2022 at 10:27 AM Daniel P. Berrangé wrote: On Wed, Feb 23, 2022 at 10:22:11AM -0500, John Snow wrote: On Mon, Feb 21, 2022 at 10:55 AM Damien Hedde wrote: This option

Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-23 Thread John Snow
On Wed, Feb 23, 2022 at 10:44 AM Daniel P. Berrangé wrote: > > On Wed, Feb 23, 2022 at 10:41:11AM -0500, John Snow wrote: > > On Wed, Feb 23, 2022 at 10:27 AM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Feb 23, 2022 at 10:22:11AM -0500, John Snow wrote: > > > > On Mon, Feb 21, 2022 at

Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-23 Thread Daniel P . Berrangé
On Wed, Feb 23, 2022 at 10:41:11AM -0500, John Snow wrote: > On Wed, Feb 23, 2022 at 10:27 AM Daniel P. Berrangé > wrote: > > > > On Wed, Feb 23, 2022 at 10:22:11AM -0500, John Snow wrote: > > > On Mon, Feb 21, 2022 at 10:55 AM Damien Hedde > > > wrote: > > > > > > > > This option makes

Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-23 Thread John Snow
On Wed, Feb 23, 2022 at 10:27 AM Daniel P. Berrangé wrote: > > On Wed, Feb 23, 2022 at 10:22:11AM -0500, John Snow wrote: > > On Mon, Feb 21, 2022 at 10:55 AM Damien Hedde > > wrote: > > > > > > This option makes qmp_shell exit (with error code 1) > > > as soon as one of the following error

Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-23 Thread Daniel P . Berrangé
On Wed, Feb 23, 2022 at 10:22:11AM -0500, John Snow wrote: > On Mon, Feb 21, 2022 at 10:55 AM Damien Hedde > wrote: > > > > This option makes qmp_shell exit (with error code 1) > > as soon as one of the following error occurs: > > + command parsing error > > + disconnection > > + command failure

Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-23 Thread John Snow
On Mon, Feb 21, 2022 at 10:55 AM Damien Hedde wrote: > > This option makes qmp_shell exit (with error code 1) > as soon as one of the following error occurs: > + command parsing error > + disconnection > + command failure (response is an error) > > _execute_cmd() method now returns None or the

[PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option

2022-02-21 Thread Damien Hedde
This option makes qmp_shell exit (with error code 1) as soon as one of the following error occurs: + command parsing error + disconnection + command failure (response is an error) _execute_cmd() method now returns None or the response so that read_exec_command() can do the last check. This is