Re: [PATCH 4/7] s390x/css: Make S390CCWDeviceClass::realize return bool

2024-05-24 Thread Anthony Krowiak
On 5/22/24 1:01 PM, Cédric Le Goater wrote: Since the realize() handler of S390CCWDeviceClass takes an 'Error **' argument, best practices suggest to return a bool. See the api/error.h Rules section. While at it, modify the call in vfio_ccw_realize(). Signed-off-by: Cédric Le Goater

RE: [PATCH 4/7] s390x/css: Make S390CCWDeviceClass::realize return bool

2024-05-23 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: [PATCH 4/7] s390x/css: Make S390CCWDeviceClass::realize return >bool > >Since the realize() handler of S390CCWDeviceClass takes an 'Error **' >argument, best practices suggest to return a bool. See the api/e

[PATCH 4/7] s390x/css: Make S390CCWDeviceClass::realize return bool

2024-05-22 Thread Cédric Le Goater
Since the realize() handler of S390CCWDeviceClass takes an 'Error **' argument, best practices suggest to return a bool. See the api/error.h Rules section. While at it, modify the call in vfio_ccw_realize(). Signed-off-by: Cédric Le Goater --- include/hw/s390x/s390-ccw.h | 2 +-