Re: [PATCH 5/5] hw/i2c: Document the I2C qdev helpers

2020-07-14 Thread Peter Maydell
On Tue, 14 Jul 2020 at 08:06, Markus Armbruster wrote: > Since you felt a need for a more elaborate ssi_realize_and_unref() doc > comment, you should probably propose a patch for > qdev_realize_and_unref()'s doc comment :) Yes, that's part of

Re: [PATCH 5/5] hw/i2c: Document the I2C qdev helpers

2020-07-14 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 30 Jun 2020 at 11:15, Markus Armbruster wrote: >> >> Philippe Mathieu-Daudé writes: >> >> > In commit d88c42ff2c we added new prototype but neglected to >> > add their documentation. Fix that. >> > >> > Reported-by: Peter Maydell >> > Signed-off-by: Philippe

Re: [PATCH 5/5] hw/i2c: Document the I2C qdev helpers

2020-06-30 Thread Peter Maydell
On Tue, 30 Jun 2020 at 11:15, Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > > > In commit d88c42ff2c we added new prototype but neglected to > > add their documentation. Fix that. > > > > Reported-by: Peter Maydell > > Signed-off-by: Philippe Mathieu-Daudé > > + * This

Re: [PATCH 5/5] hw/i2c: Document the I2C qdev helpers

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 12:15 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> In commit d88c42ff2c we added new prototype but neglected to >> add their documentation. Fix that. >> >> Reported-by: Peter Maydell >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/hw/i2c/i2c.h | 48

Re: [PATCH 5/5] hw/i2c: Document the I2C qdev helpers

2020-06-30 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > In commit d88c42ff2c we added new prototype but neglected to > add their documentation. Fix that. > > Reported-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/i2c/i2c.h | 48 > 1 file

Re: [PATCH 5/5] hw/i2c: Document the I2C qdev helpers

2020-06-29 Thread Corey Minyard
On Mon, Jun 29, 2020 at 07:38:21PM +0200, Philippe Mathieu-Daudé wrote: > In commit d88c42ff2c we added new prototype but neglected to > add their documentation. Fix that. Reviewed-by: Corey Minyard > > Reported-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- >

[PATCH 5/5] hw/i2c: Document the I2C qdev helpers

2020-06-29 Thread Philippe Mathieu-Daudé
In commit d88c42ff2c we added new prototype but neglected to add their documentation. Fix that. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h | 48 1 file changed, 48 insertions(+) diff --git