Re: [PATCH 5/8] hw/timer/altera_timer.c: Switch to transaction-based ptimer API

2019-10-17 Thread Peter Maydell
On Thu, 17 Oct 2019 at 17:09, Philippe Mathieu-Daudé wrote: > > On 10/17/19 3:29 PM, Peter Maydell wrote: > > -t->bh = qemu_bh_new(timer_hit, t); > > -t->ptimer = ptimer_init_with_bh(t->bh, PTIMER_POLICY_DEFAULT); > > +t->ptimer = ptimer_init(timer_hit, t, PTIMER_POLICY_DEFAULT); > > +

Re: [PATCH 5/8] hw/timer/altera_timer.c: Switch to transaction-based ptimer API

2019-10-17 Thread Philippe Mathieu-Daudé
On 10/17/19 3:29 PM, Peter Maydell wrote: Switch the altera_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to cre

Re: [PATCH 5/8] hw/timer/altera_timer.c: Switch to transaction-based ptimer API

2019-10-17 Thread Richard Henderson
On 10/17/19 6:29 AM, Peter Maydell wrote: > Switch the altera_timer code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function

[PATCH 5/8] hw/timer/altera_timer.c: Switch to transaction-based ptimer API

2019-10-17 Thread Peter Maydell
Switch the altera_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter Maydell