Re: [PATCH 5/8] tests/vm: Added configuration file support

2020-01-27 Thread Robert Foley
On Mon, 27 Jan 2020 at 07:38, Alex Bennée wrote: > > +if 'password' in target_dict: > > +config['root_pass'] = target_dict['password'] > > +config['guest_pass'] = target_dict['password'] > > This seems like impedance matching between two dictionaries. Surely it >

Re: [PATCH 5/8] tests/vm: Added configuration file support

2020-01-27 Thread Alex Bennée
Robert Foley writes: > Changes to tests/vm/basevm.py to allow accepting a configuration file > as a parameter. Allows for specifying VM options such as > cpu, machine, memory, and arbitrary qemu arguments for specifying options > such as NUMA configuration. > Also added an example

[PATCH 5/8] tests/vm: Added configuration file support

2020-01-24 Thread Robert Foley
Changes to tests/vm/basevm.py to allow accepting a configuration file as a parameter. Allows for specifying VM options such as cpu, machine, memory, and arbitrary qemu arguments for specifying options such as NUMA configuration. Also added an example config_example.yml. Signed-off-by: Robert