Re: [PATCH 6/6] accel/tcg: Always require can_do_io

2023-10-26 Thread Clément Chigot
On Thu, Oct 26, 2023 at 2:44 AM Richard Henderson wrote: > > On 10/24/23 02:50, Clément Chigot wrote: > > Hi Richard, > > > > This commit has broken some of our internal bareboard testing on > > Risc-V 64. At some point in our programs, there is an AMOSWAP (= > > atomic swap) instruction on I/O.

Re: [PATCH 6/6] accel/tcg: Always require can_do_io

2023-10-25 Thread Richard Henderson
On 10/24/23 02:50, Clément Chigot wrote: Hi Richard, This commit has broken some of our internal bareboard testing on Risc-V 64. At some point in our programs, there is an AMOSWAP (= atomic swap) instruction on I/O. But since this commit, can_do_io is set to false triggering an infinite loop.

Re: [PATCH 6/6] accel/tcg: Always require can_do_io

2023-10-24 Thread Clément Chigot
Hi Richard, This commit has broken some of our internal bareboard testing on Risc-V 64. At some point in our programs, there is an AMOSWAP (= atomic swap) instruction on I/O. But since this commit, can_do_io is set to false triggering an infinite loop. IIUC the doc (cf [1]), atomic operations on

Re: [PATCH 6/6] accel/tcg: Always require can_do_io

2023-09-19 Thread Philippe Mathieu-Daudé
On 14/9/23 19:44, Richard Henderson wrote: Require i/o as the last insn of a TranslationBlock always, not only with icount. This is required for i/o that alters the address space, such as a pci config space write. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1866 Signed-off-by:

[PATCH 6/6] accel/tcg: Always require can_do_io

2023-09-14 Thread Richard Henderson
Require i/o as the last insn of a TranslationBlock always, not only with icount. This is required for i/o that alters the address space, such as a pci config space write. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1866 Signed-off-by: Richard Henderson --- accel/tcg/translator.c