Re: [PATCH 6/6] pcie: expire pending delete

2021-10-12 Thread Michael S. Tsirkin
On Tue, Oct 12, 2021 at 08:44:45AM +0200, Gerd Hoffmann wrote: > On Tue, Oct 12, 2021 at 01:46:35AM -0400, Michael S. Tsirkin wrote: > > On Tue, Oct 12, 2021 at 07:30:34AM +0200, Gerd Hoffmann wrote: > > > > > index f3ac04399969..477c8776aa27 100644 > > > > > --- a/hw/pci/pcie.c > > > > > +++

Re: [PATCH 6/6] pcie: expire pending delete

2021-10-12 Thread Gerd Hoffmann
On Tue, Oct 12, 2021 at 01:46:35AM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 12, 2021 at 07:30:34AM +0200, Gerd Hoffmann wrote: > > > > index f3ac04399969..477c8776aa27 100644 > > > > --- a/hw/pci/pcie.c > > > > +++ b/hw/pci/pcie.c > > > > @@ -549,6 +549,8 @@ void

Re: [PATCH 6/6] pcie: expire pending delete

2021-10-11 Thread Michael S. Tsirkin
On Tue, Oct 12, 2021 at 07:30:34AM +0200, Gerd Hoffmann wrote: > > > index f3ac04399969..477c8776aa27 100644 > > > --- a/hw/pci/pcie.c > > > +++ b/hw/pci/pcie.c > > > @@ -549,6 +549,8 @@ void pcie_cap_slot_unplug_request_cb(HotplugHandler > > > *hotplug_dev, > > > } > > > > > >

Re: [PATCH 6/6] pcie: expire pending delete

2021-10-11 Thread Gerd Hoffmann
> > index f3ac04399969..477c8776aa27 100644 > > --- a/hw/pci/pcie.c > > +++ b/hw/pci/pcie.c > > @@ -549,6 +549,8 @@ void pcie_cap_slot_unplug_request_cb(HotplugHandler > > *hotplug_dev, > > } > > > > dev->pending_deleted_event = true; > > +dev->pending_deleted_expires_ms = > > +

Re: [PATCH 6/6] pcie: expire pending delete

2021-10-11 Thread Michael S. Tsirkin
On Mon, Oct 11, 2021 at 02:05:04PM +0200, Gerd Hoffmann wrote: > Add an expire time for pending delete, once the time is over allow > pressing the attention button again. > > This makes pcie hotplug behave more like acpi hotplug, where one can > try sending an 'device_del' monitor command again

[PATCH 6/6] pcie: expire pending delete

2021-10-11 Thread Gerd Hoffmann
Add an expire time for pending delete, once the time is over allow pressing the attention button again. This makes pcie hotplug behave more like acpi hotplug, where one can try sending an 'device_del' monitor command again in case the guest didn't respond to the first attempt. Signed-off-by: