Re: [PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

On 3/19/2024 9:59 PM, Paolo Bonzini wrote: From: Xiaoyao Li KVM is introducing a new API to create confidential guests, which will be used by TDX and SEV-SNP but is also available for SEV and SEV-ES. The API uses the VM type argument to KVM_CREATE_VM to identify which confidential computing

Re: [PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

On Tue, Mar 19, 2024 at 03:29:14PM +0100, Paolo Bonzini wrote: > On Tue, Mar 19, 2024 at 3:27 PM Daniel P. Berrangé > wrote: > > > > On Tue, Mar 19, 2024 at 03:25:53PM +0100, Paolo Bonzini wrote: > > > On Tue, Mar 19, 2024 at 3:15 PM Daniel P. Berrangé > > > wrote: > > > > > +int

Re: [PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

On Tue, Mar 19, 2024 at 3:27 PM Daniel P. Berrangé wrote: > > On Tue, Mar 19, 2024 at 03:25:53PM +0100, Paolo Bonzini wrote: > > On Tue, Mar 19, 2024 at 3:15 PM Daniel P. Berrangé > > wrote: > > > > +int kvm_get_vm_type(MachineState *ms, const char *vm_type) > > > > > > The 'vm_type' parameter

Re: [PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

On Tue, Mar 19, 2024 at 03:25:53PM +0100, Paolo Bonzini wrote: > On Tue, Mar 19, 2024 at 3:15 PM Daniel P. Berrangé > wrote: > > > +int kvm_get_vm_type(MachineState *ms, const char *vm_type) > > > > The 'vm_type' parameter is never used here. What value is it expected > > to have, and should be

Re: [PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

On Tue, Mar 19, 2024 at 02:59:59PM +0100, Paolo Bonzini wrote: > From: Xiaoyao Li > > KVM is introducing a new API to create confidential guests, which > will be used by TDX and SEV-SNP but is also available for SEV and > SEV-ES. The API uses the VM type argument to KVM_CREATE_VM to > identify

Re: [PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

On Tue, Mar 19, 2024 at 3:15 PM Daniel P. Berrangé wrote: > > +int kvm_get_vm_type(MachineState *ms, const char *vm_type) > > The 'vm_type' parameter is never used here. What value is it expected > to have, and should be diagnosing an error if some unexpected value > is provided. It's the value

[PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

From: Xiaoyao Li KVM is introducing a new API to create confidential guests, which will be used by TDX and SEV-SNP but is also available for SEV and SEV-ES. The API uses the VM type argument to KVM_CREATE_VM to identify which confidential computing technology to use. Since there are no other