Re: [PATCH 6/8] spapr/drc: Clean up local variable shadowing in rtas_ibm_configure_connector()

2023-09-28 Thread Harsh Prateek Bora
On 9/29/23 11:04, Markus Armbruster wrote: Harsh Prateek Bora writes: On Tue, 19 Sept, 2023, 5:33 pm Cédric Le Goater, wrote: On 9/19/23 10:29, Harsh Prateek Bora wrote: On 9/18/23 20:28, Cédric Le Goater wrote: Remove extra 'drc_index' variable to avoid this warning : ../hw/ppc

Re: [PATCH 6/8] spapr/drc: Clean up local variable shadowing in rtas_ibm_configure_connector()

2023-09-28 Thread Markus Armbruster
Harsh Prateek Bora writes: > On Tue, 19 Sept, 2023, 5:33 pm Cédric Le Goater, wrote: > >> On 9/19/23 10:29, Harsh Prateek Bora wrote: >> > >> > >> > On 9/18/23 20:28, Cédric Le Goater wrote: >> >> Remove extra 'drc_index' variable to avoid this warning : >> >> >> >>../hw/ppc/spapr_drc.c: In

Re: [PATCH 6/8] spapr/drc: Clean up local variable shadowing in rtas_ibm_configure_connector()

2023-09-19 Thread Harsh Prateek Bora
On Tue, 19 Sept, 2023, 5:33 pm Cédric Le Goater, wrote: > On 9/19/23 10:29, Harsh Prateek Bora wrote: > > > > > > On 9/18/23 20:28, Cédric Le Goater wrote: > >> Remove extra 'drc_index' variable to avoid this warning : > >> > >>../hw/ppc/spapr_drc.c: In function ‘rtas_ibm_configure_connector’

Re: [PATCH 6/8] spapr/drc: Clean up local variable shadowing in rtas_ibm_configure_connector()

2023-09-19 Thread Cédric Le Goater
On 9/19/23 10:29, Harsh Prateek Bora wrote: On 9/18/23 20:28, Cédric Le Goater wrote: Remove extra 'drc_index' variable to avoid this warning :    ../hw/ppc/spapr_drc.c: In function ‘rtas_ibm_configure_connector’:    ../hw/ppc/spapr_drc.c:1240:26: warning: declaration of ‘drc_index’ shadows a

Re: [PATCH 6/8] spapr/drc: Clean up local variable shadowing in rtas_ibm_configure_connector()

2023-09-19 Thread Harsh Prateek Bora
On 9/18/23 20:28, Cédric Le Goater wrote: Remove extra 'drc_index' variable to avoid this warning : ../hw/ppc/spapr_drc.c: In function ‘rtas_ibm_configure_connector’: ../hw/ppc/spapr_drc.c:1240:26: warning: declaration of ‘drc_index’ shadows a previous local [-Wshadow=compatible-local]

[PATCH 6/8] spapr/drc: Clean up local variable shadowing in rtas_ibm_configure_connector()

2023-09-18 Thread Cédric Le Goater
Remove extra 'drc_index' variable to avoid this warning : ../hw/ppc/spapr_drc.c: In function ‘rtas_ibm_configure_connector’: ../hw/ppc/spapr_drc.c:1240:26: warning: declaration of ‘drc_index’ shadows a previous local [-Wshadow=compatible-local] 1240 | uint32_t drc_index = s