Re: [Virtio-fs] [PATCH 7/7] virtiofsd: Set req->reply_sent right after sending reply

2021-05-18 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Thu, May 13, 2021 at 03:50:13PM -0500, Connor Kuehl wrote: > > On 5/11/21 4:37 PM, Vivek Goyal wrote: > > > There is no reason to set it in label "err". We should be able to set > > > it right after sending reply. It is easier to read. > > > > > >

Re: [PATCH 7/7] virtiofsd: Set req->reply_sent right after sending reply

2021-05-18 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > There is no reason to set it in label "err". We should be able to set > it right after sending reply. It is easier to read. > > Signed-off-by: Vivek Goyal Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_virtio.c | 5 + > 1 file

Re: [Virtio-fs] [PATCH 7/7] virtiofsd: Set req->reply_sent right after sending reply

2021-05-17 Thread Vivek Goyal
On Thu, May 13, 2021 at 03:50:13PM -0500, Connor Kuehl wrote: > On 5/11/21 4:37 PM, Vivek Goyal wrote: > > There is no reason to set it in label "err". We should be able to set > > it right after sending reply. It is easier to read. > > > > Signed-off-by: Vivek Goyal > > --- > >

Re: [Virtio-fs] [PATCH 7/7] virtiofsd: Set req->reply_sent right after sending reply

2021-05-13 Thread Connor Kuehl
On 5/11/21 4:37 PM, Vivek Goyal wrote: > There is no reason to set it in label "err". We should be able to set > it right after sending reply. It is easier to read. > > Signed-off-by: Vivek Goyal > --- > tools/virtiofsd/fuse_virtio.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) >

[PATCH 7/7] virtiofsd: Set req->reply_sent right after sending reply

2021-05-11 Thread Vivek Goyal
There is no reason to set it in label "err". We should be able to set it right after sending reply. It is easier to read. Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_virtio.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/virtiofsd/fuse_virtio.c