Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-18 Thread Daniel P . Berrangé
On Fri, May 17, 2024 at 07:43:35PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > > > The only caller of monitor_fdset_dup_fd_add is qemu_open_internal > > and that has a "Error **errp" parameter. We should rewrite > > monitor_fdset_dup_fd_add to also have an "Error **errp" at

Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-17 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Wed, May 08, 2024 at 05:39:53PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Wed, May 08, 2024 at 09:53:48AM +0100, Daniel P. Berrangé wrote: >> >> On Fri, Apr 26, 2024 at 11:20:41AM -0300, Fabiano Rosas wrote: >> >> > Allow multifd to use an fdset

Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-09 Thread Daniel P . Berrangé
On Wed, May 08, 2024 at 05:39:53PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Wed, May 08, 2024 at 09:53:48AM +0100, Daniel P. Berrangé wrote: > >> On Fri, Apr 26, 2024 at 11:20:41AM -0300, Fabiano Rosas wrote: > >> > Allow multifd to use an fdset when migrating to a file. This is

Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-08 Thread Fabiano Rosas
Peter Xu writes: > On Wed, May 08, 2024 at 09:53:48AM +0100, Daniel P. Berrangé wrote: >> On Fri, Apr 26, 2024 at 11:20:41AM -0300, Fabiano Rosas wrote: >> > Allow multifd to use an fdset when migrating to a file. This is useful >> > for the scenario where the management layer wants to have

Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-08 Thread Peter Xu
On Wed, May 08, 2024 at 09:53:48AM +0100, Daniel P. Berrangé wrote: > On Fri, Apr 26, 2024 at 11:20:41AM -0300, Fabiano Rosas wrote: > > Allow multifd to use an fdset when migrating to a file. This is useful > > for the scenario where the management layer wants to have control over > > the

Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-08 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 11:20:41AM -0300, Fabiano Rosas wrote: > Allow multifd to use an fdset when migrating to a file. This is useful > for the scenario where the management layer wants to have control over > the migration file. > > By receiving the file descriptors directly, QEMU can delegate

[PATCH 8/9] migration: Add support for fdset with multifd + file

2024-04-26 Thread Fabiano Rosas
Allow multifd to use an fdset when migrating to a file. This is useful for the scenario where the management layer wants to have control over the migration file. By receiving the file descriptors directly, QEMU can delegate some high level operating system operations to the management layer (such