Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-20 Thread Eduardo Habkost
On Tue, Apr 20, 2021 at 03:10:44PM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Tue, Apr 20, 2021 at 12:51:43PM +0100, Dr. David Alan Gilbert wrote: > > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > > On Mon, Apr 19, 2021 at 07:47:34PM +0100,

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-20 Thread Daniel P . Berrangé
On Tue, Apr 20, 2021 at 03:10:44PM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Tue, Apr 20, 2021 at 12:51:43PM +0100, Dr. David Alan Gilbert wrote: > > > I prefer things that are fairly obvious without needing to look at the > > > documentation until

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-20 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Tue, Apr 20, 2021 at 12:51:43PM +0100, Dr. David Alan Gilbert wrote: > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > On Mon, Apr 19, 2021 at 07:47:34PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé (berra...@redhat.com

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-20 Thread Eduardo Habkost
On Tue, Apr 20, 2021 at 12:51:43PM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Mon, Apr 19, 2021 at 07:47:34PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Mon, Apr 19, 2021 at 06:15:56PM +01

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-20 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Mon, Apr 19, 2021 at 07:47:34PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Mon, Apr 19, 2021 at 06:15:56PM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Apr 19, 2021 at 06:11:47PM +0100,

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Eduardo Habkost
On Mon, Apr 19, 2021 at 07:47:34PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Mon, Apr 19, 2021 at 06:15:56PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Apr 19, 2021 at 06:11:47PM +0100, Dr. David Alan Gilbert wrote: > > > > * Eduardo Habkost

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Apr 19, 2021 at 06:15:56PM +0100, Daniel P. Berrangé wrote: > > On Mon, Apr 19, 2021 at 06:11:47PM +0100, Dr. David Alan Gilbert wrote: > > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > > I would make live migration policy an enum

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Daniel P . Berrangé
On Mon, Apr 19, 2021 at 06:11:47PM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Fri, Apr 16, 2021 at 09:33:28AM +0200, Vitaly Kuznetsov wrote: > > > "Dr. David Alan Gilbert" writes: > > > > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Daniel P . Berrangé
On Mon, Apr 19, 2021 at 06:15:56PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 06:11:47PM +0100, Dr. David Alan Gilbert wrote: > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > I would make live migration policy an enum, just to make sure > > > we are explicit about the requir

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Fri, Apr 16, 2021 at 09:33:28AM +0200, Vitaly Kuznetsov wrote: > > "Dr. David Alan Gilbert" writes: > > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > >> On Thu, Apr 15, 2021 at 05:44:02PM +0200, Vitaly Kuznetsov wrote: > > >> > Whe

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Eduardo Habkost
On Mon, Apr 19, 2021 at 12:42 PM Daniel P. Berrangé wrote: > > On Fri, Apr 16, 2021 at 12:28:01PM -0400, Eduardo Habkost wrote: > > On Fri, Apr 16, 2021 at 09:33:28AM +0200, Vitaly Kuznetsov wrote: > > > "Dr. David Alan Gilbert" writes: > > > > > > > * Daniel P. Berrangé (berra...@redhat.com) wro

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Daniel P . Berrangé
On Fri, Apr 16, 2021 at 12:28:01PM -0400, Eduardo Habkost wrote: > On Fri, Apr 16, 2021 at 09:33:28AM +0200, Vitaly Kuznetsov wrote: > > "Dr. David Alan Gilbert" writes: > > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > >> On Thu, Apr 15, 2021 at 05:44:02PM +0200, Vitaly Kuznetsov w

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Daniel P . Berrangé
On Mon, Apr 19, 2021 at 12:28:04PM -0400, Eduardo Habkost wrote: > On Sun, Apr 18, 2021 at 11:54 AM Peter Maydell > wrote: > > > > On Thu, 15 Apr 2021 at 16:46, Vitaly Kuznetsov wrote: > > > When a migration blocker is added nothing is reported to the user, > > > inability to migrate such guest

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Eduardo Habkost
On Sun, Apr 18, 2021 at 11:54 AM Peter Maydell wrote: > > On Thu, 15 Apr 2021 at 16:46, Vitaly Kuznetsov wrote: > > When a migration blocker is added nothing is reported to the user, > > inability to migrate such guest may come as a late surprise. As a bare > > minimum, we can print a warning. To

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Markus Armbruster
Markus Armbruster writes: [...] > Apropos blocked-reasons. migration.json has: > > # @blocked: True if outgoing migration is blocked (since 6.0) > # > # @blocked-reasons: A list of reasons an outgoing migration is blocked > (since 6.0) > [...] > 'blocked': 'bool',

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-19 Thread Markus Armbruster
Markus Armbruster writes: > Vitaly Kuznetsov writes: > >> When a migration blocker is added nothing is reported to the user, >> inability to migrate such guest may come as a late surprise. As a bare >> minimum, we can print a warning. To not pollute the output for those, who >> have no intention

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-18 Thread Peter Maydell
On Thu, 15 Apr 2021 at 16:46, Vitaly Kuznetsov wrote: > When a migration blocker is added nothing is reported to the user, > inability to migrate such guest may come as a late surprise. As a bare > minimum, we can print a warning. To not pollute the output for those, who > have no intention to mig

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-17 Thread Markus Armbruster
Vitaly Kuznetsov writes: > When a migration blocker is added nothing is reported to the user, > inability to migrate such guest may come as a late surprise. As a bare > minimum, we can print a warning. To not pollute the output for those, who > have no intention to migrate their guests, introduce

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-17 Thread Markus Armbruster
Eduardo Habkost writes: [...] > I would make live migration policy an enum, just to make sure > we are explicit about the requirements: > > - UNKNOWN: this is the current state in QEMU 6.0, where we don't > really know what the user expects. > This can be the default on existing versioned mac

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-16 Thread Eduardo Habkost
On Fri, Apr 16, 2021 at 09:33:28AM +0200, Vitaly Kuznetsov wrote: > "Dr. David Alan Gilbert" writes: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >> On Thu, Apr 15, 2021 at 05:44:02PM +0200, Vitaly Kuznetsov wrote: > >> > When a migration blocker is added nothing is reported to the u

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-16 Thread Vitaly Kuznetsov
"Dr. David Alan Gilbert" writes: > * Daniel P. Berrangé (berra...@redhat.com) wrote: >> On Thu, Apr 15, 2021 at 05:44:02PM +0200, Vitaly Kuznetsov wrote: >> > When a migration blocker is added nothing is reported to the user, >> > inability to migrate such guest may come as a late surprise. As a

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-15 Thread Daniel P . Berrangé
On Thu, Apr 15, 2021 at 05:40:40PM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 15, 2021 at 12:30:11PM -0400, Eduardo Habkost wrote: > > On Thu, Apr 15, 2021 at 12:04 PM Daniel P. Berrangé > > wrote: > > > > > > Is it possible to query the migration blockers via QMP ? > > > > I don't think it

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Apr 15, 2021 at 05:44:02PM +0200, Vitaly Kuznetsov wrote: > > When a migration blocker is added nothing is reported to the user, > > inability to migrate such guest may come as a late surprise. As a bare > > minimum, we can print a warning

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-15 Thread Daniel P . Berrangé
On Thu, Apr 15, 2021 at 12:30:11PM -0400, Eduardo Habkost wrote: > On Thu, Apr 15, 2021 at 12:04 PM Daniel P. Berrangé > wrote: > > > > On Thu, Apr 15, 2021 at 05:44:02PM +0200, Vitaly Kuznetsov wrote: > > > When a migration blocker is added nothing is reported to the user, > > > inability to mig

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-15 Thread Eduardo Habkost
On Thu, Apr 15, 2021 at 12:04 PM Daniel P. Berrangé wrote: > > On Thu, Apr 15, 2021 at 05:44:02PM +0200, Vitaly Kuznetsov wrote: > > When a migration blocker is added nothing is reported to the user, > > inability to migrate such guest may come as a late surprise. As a bare > > minimum, we can pri

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-15 Thread Daniel P . Berrangé
On Thu, Apr 15, 2021 at 05:44:02PM +0200, Vitaly Kuznetsov wrote: > When a migration blocker is added nothing is reported to the user, > inability to migrate such guest may come as a late surprise. As a bare > minimum, we can print a warning. To not pollute the output for those, who > have no inten

[PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-15 Thread Vitaly Kuznetsov
When a migration blocker is added nothing is reported to the user, inability to migrate such guest may come as a late surprise. As a bare minimum, we can print a warning. To not pollute the output for those, who have no intention to migrate their guests, introduce '--no-migration' option which both