Re: [PATCH RFC 02/21] util: Include osdep.h first in util/mmap-alloc.c

2023-01-29 Thread Juan Quintela
Peter Xu wrote: > Without it, we never have CONFIG_LINUX defined even if on linux, so > linux/mman.h is never really included. > > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Markus is working on this right now, Markus?

Re: [PATCH RFC 02/21] util: Include osdep.h first in util/mmap-alloc.c

2023-01-24 Thread Philippe Mathieu-Daudé
On 17/1/23 23:08, Peter Xu wrote: Without it, we never have CONFIG_LINUX defined even if on linux, so linux/mman.h is never really included. Signed-off-by: Peter Xu --- util/mmap-alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH RFC 02/21] util: Include osdep.h first in util/mmap-alloc.c

2023-01-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Without it, we never have CONFIG_LINUX defined even if on linux, so > linux/mman.h is never really included. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > util/mmap-alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH RFC 02/21] util: Include osdep.h first in util/mmap-alloc.c

2023-01-17 Thread Peter Xu
Without it, we never have CONFIG_LINUX defined even if on linux, so linux/mman.h is never really included. Signed-off-by: Peter Xu --- util/mmap-alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c index 5ed7d29183..040599b0e3 100644