Re: [PATCH V4 1/3] hw/arm, loongarch: Move load_image_to_fw_cfg() to common location

2022-09-22 Thread Sunil V L
On Thu, Sep 15, 2022 at 08:56:01PM +0800, gaosong wrote: > > 在 2022/9/15 下午7:59, Sunil V L 写道: > > Hi, > > > > Could maintainers of hw/arm and hw/loongarch to take a look at this? I > > have addressed Peter's earlier comment. > > > > Thanks > > Sunil > > > > On Thu, Sep 08, 2022 at 11:17:52AM +

Re: [PATCH V4 1/3] hw/arm, loongarch: Move load_image_to_fw_cfg() to common location

2022-09-15 Thread gaosong
在 2022/9/15 下午7:59, Sunil V L 写道: Hi, Could maintainers of hw/arm and hw/loongarch to take a look at this? I have addressed Peter's earlier comment. Thanks Sunil On Thu, Sep 08, 2022 at 11:17:52AM +0200, Alistair Francis wrote: On Tue, Sep 6, 2022 at 11:38 AM Sunil V L wrote: load_image_t

Re: [PATCH V4 1/3] hw/arm, loongarch: Move load_image_to_fw_cfg() to common location

2022-09-15 Thread Sunil V L
Hi, Could maintainers of hw/arm and hw/loongarch to take a look at this? I have addressed Peter's earlier comment. Thanks Sunil On Thu, Sep 08, 2022 at 11:17:52AM +0200, Alistair Francis wrote: > On Tue, Sep 6, 2022 at 11:38 AM Sunil V L wrote: > > > > load_image_to_fw_cfg() is duplicated by bo

Re: [PATCH V4 1/3] hw/arm, loongarch: Move load_image_to_fw_cfg() to common location

2022-09-08 Thread Alistair Francis
On Tue, Sep 6, 2022 at 11:38 AM Sunil V L wrote: > > load_image_to_fw_cfg() is duplicated by both arm and loongarch. The same > function will be required by riscv too. So, it's time to refactor and > move this function to a common path. > > Signed-off-by: Sunil V L > Reviewed-by: Andrew Jones R

Re: [PATCH V4 1/3] hw/arm,loongarch: Move load_image_to_fw_cfg() to common location

2022-09-06 Thread Philippe Mathieu-Daudé via
On 6/9/22 11:02, Sunil V L wrote: load_image_to_fw_cfg() is duplicated by both arm and loongarch. The same function will be required by riscv too. So, it's time to refactor and move this function to a common path. Signed-off-by: Sunil V L Reviewed-by: Andrew Jones --- hw/arm/boot.c

[PATCH V4 1/3] hw/arm, loongarch: Move load_image_to_fw_cfg() to common location

2022-09-06 Thread Sunil V L
load_image_to_fw_cfg() is duplicated by both arm and loongarch. The same function will be required by riscv too. So, it's time to refactor and move this function to a common path. Signed-off-by: Sunil V L Reviewed-by: Andrew Jones --- hw/arm/boot.c | 49 -