Re: [Virtio-fs] [PATCH for-5.1 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-23 Thread Stefan Hajnoczi
On Thu, Jul 23, 2020 at 09:56:03AM -0400, Vivek Goyal wrote: > On Thu, Jul 23, 2020 at 01:50:35PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 23, 2020 at 01:46:11PM +0100, Stefan Hajnoczi wrote: > > > On Wed, Jul 22, 2020 at 06:03:28PM +0100, Daniel P. Berrangé wrote: > > > > On Wed, Jul 22,

Re: [Virtio-fs] [PATCH for-5.1 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-23 Thread Vivek Goyal
On Thu, Jul 23, 2020 at 01:50:35PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 23, 2020 at 01:46:11PM +0100, Stefan Hajnoczi wrote: > > On Wed, Jul 22, 2020 at 06:03:28PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Jul 22, 2020 at 02:02:06PM +0100, Stefan Hajnoczi wrote: > > > > An

Re: [PATCH for-5.1 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-23 Thread Daniel P . Berrangé
On Thu, Jul 23, 2020 at 01:46:11PM +0100, Stefan Hajnoczi wrote: > On Wed, Jul 22, 2020 at 06:03:28PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 22, 2020 at 02:02:06PM +0100, Stefan Hajnoczi wrote: > > > An assertion failure is raised during request processing if > > > unshare(CLONE_FS)

Re: [PATCH for-5.1 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-23 Thread Stefan Hajnoczi
On Wed, Jul 22, 2020 at 06:03:28PM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 22, 2020 at 02:02:06PM +0100, Stefan Hajnoczi wrote: > > An assertion failure is raised during request processing if > > unshare(CLONE_FS) fails. Implement a probe at startup so the problem can > > be detected right

Re: [PATCH for-5.1 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-22 Thread Daniel P . Berrangé
On Wed, Jul 22, 2020 at 02:02:06PM +0100, Stefan Hajnoczi wrote: > An assertion failure is raised during request processing if > unshare(CLONE_FS) fails. Implement a probe at startup so the problem can > be detected right away. > > Unfortunately Docker/Moby does not include unshare in the

[PATCH for-5.1 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-22 Thread Stefan Hajnoczi
An assertion failure is raised during request processing if unshare(CLONE_FS) fails. Implement a probe at startup so the problem can be detected right away. Unfortunately Docker/Moby does not include unshare in the seccomp.json list unless CAP_SYS_ADMIN is given. Other seccomp.json lists always