Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-27 Thread Greg Kurz
On Fri, 27 Nov 2020 15:59:16 +1100 David Gibson wrote: [...] > > > > This can't happen AFAICT. > > > > (qemu) qom-get /machine/unattached/device[1] core-id > > 0 > > (qemu) device_del /machine/unattached/device[1] > > Error: Boot CPU core may not be unplugged > > > > commit

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-26 Thread David Gibson
On Thu, Nov 26, 2020 at 10:10:27AM +0100, Greg Kurz wrote: > On Thu, 26 Nov 2020 15:57:37 +1100 > David Gibson wrote: > > > On Wed, Nov 25, 2020 at 10:51:05AM +0100, Greg Kurz wrote: > > > On Wed, 25 Nov 2020 13:39:47 +1100 > > > David Gibson wrote: > > > > > > > On Mon, Nov 23, 2020 at

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-26 Thread Igor Mammedov
On Thu, 26 Nov 2020 17:23:20 +0100 Igor Mammedov wrote: > On Thu, 26 Nov 2020 10:10:27 +0100 > Greg Kurz wrote: > > > On Thu, 26 Nov 2020 15:57:37 +1100 > > David Gibson wrote: > > > > > On Wed, Nov 25, 2020 at 10:51:05AM +0100, Greg Kurz wrote: > > > > On Wed, 25 Nov 2020 13:39:47

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-26 Thread Igor Mammedov
On Thu, 26 Nov 2020 10:10:27 +0100 Greg Kurz wrote: > On Thu, 26 Nov 2020 15:57:37 +1100 > David Gibson wrote: > > > On Wed, Nov 25, 2020 at 10:51:05AM +0100, Greg Kurz wrote: > > > On Wed, 25 Nov 2020 13:39:47 +1100 > > > David Gibson wrote: > > > > > > > On Mon, Nov 23, 2020 at

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-26 Thread Greg Kurz
On Thu, 26 Nov 2020 15:57:37 +1100 David Gibson wrote: > On Wed, Nov 25, 2020 at 10:51:05AM +0100, Greg Kurz wrote: > > On Wed, 25 Nov 2020 13:39:47 +1100 > > David Gibson wrote: > > > > > On Mon, Nov 23, 2020 at 12:51:08PM +0100, Greg Kurz wrote: > > > > On Mon, 23 Nov 2020 16:11:30 +1100 > >

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-25 Thread David Gibson
On Wed, Nov 25, 2020 at 10:51:05AM +0100, Greg Kurz wrote: > On Wed, 25 Nov 2020 13:39:47 +1100 > David Gibson wrote: > > > On Mon, Nov 23, 2020 at 12:51:08PM +0100, Greg Kurz wrote: > > > On Mon, 23 Nov 2020 16:11:30 +1100 > > > David Gibson wrote: > > > > > > > On Sat, Nov 21, 2020 at

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-25 Thread Greg Kurz
On Wed, 25 Nov 2020 13:39:47 +1100 David Gibson wrote: > On Mon, Nov 23, 2020 at 12:51:08PM +0100, Greg Kurz wrote: > > On Mon, 23 Nov 2020 16:11:30 +1100 > > David Gibson wrote: > > > > > On Sat, Nov 21, 2020 at 12:42:03AM +0100, Greg Kurz wrote: > > > > When it comes to resetting the compat

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-24 Thread David Gibson
On Mon, Nov 23, 2020 at 12:51:08PM +0100, Greg Kurz wrote: > On Mon, 23 Nov 2020 16:11:30 +1100 > David Gibson wrote: > > > On Sat, Nov 21, 2020 at 12:42:03AM +0100, Greg Kurz wrote: > > > When it comes to resetting the compat mode of the vCPUS, there are > > > two situations to consider: > > >

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-23 Thread Greg Kurz
On Mon, 23 Nov 2020 16:11:30 +1100 David Gibson wrote: > On Sat, Nov 21, 2020 at 12:42:03AM +0100, Greg Kurz wrote: > > When it comes to resetting the compat mode of the vCPUS, there are > > two situations to consider: > > (1) machine reset should set the compat mode back to the machine default,

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-22 Thread David Gibson
On Sat, Nov 21, 2020 at 12:42:03AM +0100, Greg Kurz wrote: > When it comes to resetting the compat mode of the vCPUS, there are > two situations to consider: > (1) machine reset should set the compat mode back to the machine default, > ie. spapr->max_compat_pvr > (2) hot plugged vCPUs should

[PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-20 Thread Greg Kurz
When it comes to resetting the compat mode of the vCPUS, there are two situations to consider: (1) machine reset should set the compat mode back to the machine default, ie. spapr->max_compat_pvr (2) hot plugged vCPUs should set their compat mode to mach the boot vCPU, ie.