Re: [PATCH for-6.1 v6 14/17] accel/tcg: Move breakpoint recognition outside translation

2023-11-29 Thread Max Filippov
On Tue, Nov 28, 2023 at 10:06 AM Richard Henderson wrote: > On 11/28/23 05:08, Philippe Mathieu-Daudé wrote: > > (In sysemu there is a single use in Xtensa tb_invalidate_virtual_addr). > > I suspect that should be migrated to use the common HW breakpoint support. I'm taking a look. -- Thanks.

Re: [PATCH for-6.1 v6 14/17] accel/tcg: Move breakpoint recognition outside translation

2023-11-28 Thread Richard Henderson
On 11/28/23 05:08, Philippe Mathieu-Daudé wrote: Hi, On 20/7/21 21:54, Richard Henderson wrote: Trigger breakpoints before beginning translation of a TB that would begin with a BP.  Thus we never generate code for the BP at all. Single-step instructions within a page containing a BP so that

Re: [PATCH for-6.1 v6 14/17] accel/tcg: Move breakpoint recognition outside translation

2023-11-28 Thread Philippe Mathieu-Daudé
Hi, On 20/7/21 21:54, Richard Henderson wrote: Trigger breakpoints before beginning translation of a TB that would begin with a BP. Thus we never generate code for the BP at all. Single-step instructions within a page containing a BP so that we are sure to check each insn for the BP as above.

[PATCH for-6.1 v6 14/17] accel/tcg: Move breakpoint recognition outside translation

2021-07-20 Thread Richard Henderson
Trigger breakpoints before beginning translation of a TB that would begin with a BP. Thus we never generate code for the BP at all. Single-step instructions within a page containing a BP so that we are sure to check each insn for the BP as above. We no longer need to flush any TBs when changing