Re: [PATCH for-6.2 03/34] target/arm: Fix MVE VSLI by 0 and VSRI by

2021-07-16 Thread Richard Henderson
On 7/13/21 6:36 AM, Peter Maydell wrote: if (shift == 0 || shift == ESIZE * 8) { \ /* \ * Only VSLI can shift by 0; only VSRI can shift by . \ * The generic

[PATCH for-6.2 03/34] target/arm: Fix MVE VSLI by 0 and VSRI by

2021-07-13 Thread Peter Maydell
In the MVE shift-and-insert insns, we special case VSLI by 0 and VSRI by , both of which mean "no shift". However we incorrectly implemented these as "don't update the destination", which works only if Qd == Qm. When Qd != Qm this kind of shift must update Qd, honouring the predicate mask.