Re: [PATCH for-8.1 2/3] target/arm: Fix S1_ptw_translate() debug path

2023-07-13 Thread Richard Henderson
On 7/10/23 16:21, Peter Maydell wrote: In commit XXX we rearranged the logic in S1_ptw_translate() so that the debug-access "call get_phys_addr_*" codepath is used both when S1 is doing ptw reads from stage 2 and when it is doing ptw reads from physical memory. However, we didn't update the

Re: [PATCH for-8.1 2/3] target/arm: Fix S1_ptw_translate() debug path

2023-07-11 Thread Jean-Philippe Brucker
On Mon, Jul 10, 2023 at 04:21:29PM +0100, Peter Maydell wrote: > In commit XXX we rearranged the logic in S1_ptw_translate() so that > the debug-access "call get_phys_addr_*" codepath is used both when S1 > is doing ptw reads from stage 2 and when it is doing ptw reads from > physical memory.

Re: [PATCH for-8.1 2/3] target/arm: Fix S1_ptw_translate() debug path

2023-07-10 Thread Peter Maydell
On Mon, 10 Jul 2023 at 16:21, Peter Maydell wrote: > > In commit XXX we rearranged the logic in S1_ptw_translate() so that Should read "commit fe4a5472ccd6" -- I put in the Fixes: tag below but forgot to update the placeholder in the commit message text... > the debug-access "call

[PATCH for-8.1 2/3] target/arm: Fix S1_ptw_translate() debug path

2023-07-10 Thread Peter Maydell
In commit XXX we rearranged the logic in S1_ptw_translate() so that the debug-access "call get_phys_addr_*" codepath is used both when S1 is doing ptw reads from stage 2 and when it is doing ptw reads from physical memory. However, we didn't update the calculation of s2ptw->in_space and