Re: [PATCH qemu] target/s390x: support PRNO_TRNG instruction

2022-07-19 Thread Jason A. Donenfeld
Hi Thomas, On Tue, Jul 19, 2022 at 12:00 PM Thomas Huth wrote: > > +{ > > +uint64_t addr = wrap_address(env, buf); > > I think you have to limit "len" to the lower 32-bit if not running in 64-bit > mode. Will do. > According to the Principles of Operation: > > "A specification exception

Re: [PATCH qemu] target/s390x: support PRNO_TRNG instruction

2022-07-19 Thread Jason A. Donenfeld
Hi David, Thanks for your feedback. I'll CC you on v+1. Note that I don't know very much about s390x, so I may require some slight hand holding, but let's see how far I can get... On Tue, Jul 19, 2022 at 11:54:04AM +0200, David Hildenbrand wrote: > How is that warning avoided now? We have to sort

Re: [PATCH qemu] target/s390x: support PRNO_TRNG instruction

2022-07-19 Thread Thomas Huth
Hi Jason, thanks for you patch! Additionally to the things that David already mentioned, please have also a look at my comments below... On 12/07/2022 18.46, Jason A. Donenfeld wrote: In order for hosts running inside of TCG to initialize the kernel's random number generator, we should sup

Re: [PATCH qemu] target/s390x: support PRNO_TRNG instruction

2022-07-19 Thread David Hildenbrand
On 12.07.22 18:46, Jason A. Donenfeld wrote: > In order for hosts running inside of TCG to initialize the kernel's > random number generator, we should support the PRNO_TRNG instruction, > backed in the usual way with the qemu_guest_getrandom helper. This is > confirmed working on Linux 5.19-rc6. >

[PATCH qemu] target/s390x: support PRNO_TRNG instruction

2022-07-12 Thread Jason A. Donenfeld
In order for hosts running inside of TCG to initialize the kernel's random number generator, we should support the PRNO_TRNG instruction, backed in the usual way with the qemu_guest_getrandom helper. This is confirmed working on Linux 5.19-rc6. Cc: Thomas Huth Cc: Richard Henderson Cc: Harald Fr