Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-09-13 Thread Stephen Brennan
Marc-André Lureau writes: > Hi > > On Wed, Aug 23, 2023 at 2:03 PM Marc-André Lureau > wrote: >> >> Hi >> >> On Wed, Aug 23, 2023 at 4:31 AM Stephen Brennan >> wrote: >> > >> > Stephen Brennan writes: >> > > Marc-André Lureau writes: >> > >> I am a bit reluctant to change the dump format by

Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-09-13 Thread Stephen Brennan
Daniel P. Berrangé writes: > On Tue, Sep 12, 2023 at 10:34:04AM +0400, Marc-André Lureau wrote: >> Hi >> >> On Wed, Aug 23, 2023 at 2:03 PM Marc-André Lureau >> wrote: >> > >> > Hi >> > >> > On Wed, Aug 23, 2023 at 4:31 AM Stephen Brennan >> > wrote: >> > > >> > > Stephen Brennan writes: >> >

Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-09-12 Thread Omar Sandoval
On Tue, Sep 12, 2023 at 10:34:04AM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Aug 23, 2023 at 2:03 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Wed, Aug 23, 2023 at 4:31 AM Stephen Brennan > > wrote: > > > > > > Stephen Brennan writes: > > > > Marc-André Lureau writes: > > > >> I

Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-09-12 Thread Daniel P . Berrangé
On Tue, Sep 12, 2023 at 10:34:04AM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Aug 23, 2023 at 2:03 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Wed, Aug 23, 2023 at 4:31 AM Stephen Brennan > > wrote: > > > > > > Stephen Brennan writes: > > > > Marc-André Lureau writes: > > > >> I

Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-09-12 Thread Thomas Huth
On Tue, 2023-09-12 at 10:34 +0400, Marc-André Lureau wrote: > Hi > > On Wed, Aug 23, 2023 at 2:03 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Wed, Aug 23, 2023 at 4:31 AM Stephen Brennan > > wrote: > > > > > > Stephen Brennan writes: > > > > Marc-André Lureau writes: > > > > > I am

Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-09-12 Thread Marc-André Lureau
Hi On Wed, Aug 23, 2023 at 2:03 PM Marc-André Lureau wrote: > > Hi > > On Wed, Aug 23, 2023 at 4:31 AM Stephen Brennan > wrote: > > > > Stephen Brennan writes: > > > Marc-André Lureau writes: > > >> I am a bit reluctant to change the dump format by default. But since the > > >> flatten format

Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-08-23 Thread Marc-André Lureau
Hi On Wed, Aug 23, 2023 at 4:31 AM Stephen Brennan wrote: > > Stephen Brennan writes: > > Marc-André Lureau writes: > >> I am a bit reluctant to change the dump format by default. But since the > >> flatten format is more "complicated" than the "normal" format, perhaps we > >> can assume all

Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-08-22 Thread Stephen Brennan
Stephen Brennan writes: > Marc-André Lureau writes: >> I am a bit reluctant to change the dump format by default. But since the >> flatten format is more "complicated" than the "normal" format, perhaps we >> can assume all users will handle it. >> >> The change is probably late for 8.1 though..

Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-07-18 Thread Stephen Brennan
Marc-André Lureau writes: > Hi > > On Mon, Jul 17, 2023 at 8:45 PM Stephen Brennan < > stephen.s.bren...@oracle.com> wrote: > >> The flattened format is used by makedumpfile only when it is outputting >> a vmcore to a file which is not seekable. The flattened format functions >> essentially as a

Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-07-18 Thread Marc-André Lureau
Hi On Mon, Jul 17, 2023 at 8:45 PM Stephen Brennan < stephen.s.bren...@oracle.com> wrote: > The flattened format is used by makedumpfile only when it is outputting > a vmcore to a file which is not seekable. The flattened format functions > essentially as a set of instructions of the form "seek

[PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-07-17 Thread Stephen Brennan
The flattened format is used by makedumpfile only when it is outputting a vmcore to a file which is not seekable. The flattened format functions essentially as a set of instructions of the form "seek to the given offset, then write the given bytes out". The flattened format can be reconstructed