Re: [PATCH v1] aio-posix: fix build failure io_uring 2.2

2022-02-22 Thread Stefan Hajnoczi
gt; > Subject: Re: [PATCH v1] aio-posix: fix build failure io_uring 2.2 > > > > On Fri, Feb 18, 2022 at 12:16:27AM +0800, Haiyue Wang wrote: > > > The io_uring fixed "Don't truncate addr fields to 32-bit on 32-bit": > > > https://git.kernel.dk/cgit/liburing/c

Re: [PATCH v1] aio-posix: fix build failure io_uring 2.2

2022-02-22 Thread Stefan Hajnoczi
On Mon, Feb 21, 2022 at 03:54:57PM +, Peter Maydell wrote: > On Mon, 21 Feb 2022 at 15:02, Stefan Hajnoczi wrote: > > So the QEMU add_poll_remove_sqe() function would do: > > > > io_uring_prep_poll_remove(sqe, (__u64)(uintptr_t)node); > > __u64 is a linux-kernel-ism -- we should use

RE: [PATCH v1] aio-posix: fix build failure io_uring 2.2

2022-02-21 Thread Wang, Haiyue
> -Original Message- > From: Peter Maydell > Sent: Monday, February 21, 2022 23:55 > To: Stefan Hajnoczi > Cc: Wang, Haiyue ; Fam Zheng ; > qemu-devel@nongnu.org; open > list:Block I/O path > Subject: Re: [PATCH v1] aio-posix: fix build failure io_uring 2.2

RE: [PATCH v1] aio-posix: fix build failure io_uring 2.2

2022-02-21 Thread Wang, Haiyue
> -Original Message- > From: Stefan Hajnoczi > Sent: Monday, February 21, 2022 22:54 > To: Wang, Haiyue > Cc: qemu-devel@nongnu.org; Fam Zheng ; open list:Block I/O > path > Subject: Re: [PATCH v1] aio-posix: fix build failure io_uring 2.2 > > On Fri, Feb 1

Re: [PATCH v1] aio-posix: fix build failure io_uring 2.2

2022-02-21 Thread Peter Maydell
On Mon, 21 Feb 2022 at 15:02, Stefan Hajnoczi wrote: > So the QEMU add_poll_remove_sqe() function would do: > > io_uring_prep_poll_remove(sqe, (__u64)(uintptr_t)node); __u64 is a linux-kernel-ism -- we should use uint64_t, I think. thanks -- PMM

Re: [PATCH v1] aio-posix: fix build failure io_uring 2.2

2022-02-21 Thread Stefan Hajnoczi
On Fri, Feb 18, 2022 at 12:16:27AM +0800, Haiyue Wang wrote: > The io_uring fixed "Don't truncate addr fields to 32-bit on 32-bit": > https://git.kernel.dk/cgit/liburing/commit/?id=d84c29b19ed0b13619cff40141bb1fc3615b > > This leads to build failure: > ../util/fdmon-io_uring.c: In function

[PATCH v1] aio-posix: fix build failure io_uring 2.2

2022-02-17 Thread Haiyue Wang
The io_uring fixed "Don't truncate addr fields to 32-bit on 32-bit": https://git.kernel.dk/cgit/liburing/commit/?id=d84c29b19ed0b13619cff40141bb1fc3615b This leads to build failure: ../util/fdmon-io_uring.c: In function ‘add_poll_remove_sqe’: ../util/fdmon-io_uring.c:182:36: error: passing