Re: [PATCH v1] migration: tls: unref creds after used

2020-07-21 Thread Zhenyu Ye
On 2020/7/21 19:54, Daniel P. Berrangé wrote: > On Fri, Jul 17, 2020 at 05:19:43PM +0800, Zhenyu Ye wrote: >> We add the reference of creds in migration_tls_get_creds(), >> but there was no place to unref it. So the OBJECT(creds) will >> never be freed and result in memory leak. >> >> Unref the

Re: [PATCH v1] migration: tls: unref creds after used

2020-07-21 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 05:19:43PM +0800, Zhenyu Ye wrote: > We add the reference of creds in migration_tls_get_creds(), > but there was no place to unref it. So the OBJECT(creds) will > never be freed and result in memory leak. > > Unref the creds after creating the tls-channel server/client. >

[PATCH v1] migration: tls: unref creds after used

2020-07-17 Thread Zhenyu Ye
We add the reference of creds in migration_tls_get_creds(), but there was no place to unref it. So the OBJECT(creds) will never be freed and result in memory leak. Unref the creds after creating the tls-channel server/client. Signed-off-by: Zhenyu Ye --- migration/tls.c | 12 +--- 1