Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-31 Thread Christian Borntraeger
On 31.03.20 17:39, David Hildenbrand wrote: > On 31.03.20 17:33, Igor Mammedov wrote: >> On Tue, 31 Mar 2020 13:17:38 +0200 >> Christian Borntraeger wrote: >> >>> On 27.03.20 23:13, Igor Mammedov wrote: On Fri, 27 Mar 2020 17:53:39 +0100 David Hildenbrand wrote: > On

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-31 Thread Christian Borntraeger
On 31.03.20 17:33, Igor Mammedov wrote: > On Tue, 31 Mar 2020 13:17:38 +0200 > Christian Borntraeger wrote: > >> On 27.03.20 23:13, Igor Mammedov wrote: >>> On Fri, 27 Mar 2020 17:53:39 +0100 >>> David Hildenbrand wrote: >>> On 27.03.20 17:46, Igor Mammedov wrote: > On Fri, 27

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-31 Thread David Hildenbrand
On 31.03.20 17:33, Igor Mammedov wrote: > On Tue, 31 Mar 2020 13:17:38 +0200 > Christian Borntraeger wrote: > >> On 27.03.20 23:13, Igor Mammedov wrote: >>> On Fri, 27 Mar 2020 17:53:39 +0100 >>> David Hildenbrand wrote: >>> On 27.03.20 17:46, Igor Mammedov wrote: > On Fri, 27 Mar

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-31 Thread Igor Mammedov
On Tue, 31 Mar 2020 13:17:38 +0200 Christian Borntraeger wrote: > On 27.03.20 23:13, Igor Mammedov wrote: > > On Fri, 27 Mar 2020 17:53:39 +0100 > > David Hildenbrand wrote: > > > >> On 27.03.20 17:46, Igor Mammedov wrote: > >>> On Fri, 27 Mar 2020 17:05:34 +0100 > >>> Christian

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-31 Thread Christian Borntraeger
On 27.03.20 23:13, Igor Mammedov wrote: > On Fri, 27 Mar 2020 17:53:39 +0100 > David Hildenbrand wrote: > >> On 27.03.20 17:46, Igor Mammedov wrote: >>> On Fri, 27 Mar 2020 17:05:34 +0100 >>> Christian Borntraeger wrote: >>> On 27.03.20 17:01, David Hildenbrand wrote: > On

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread Igor Mammedov
On Fri, 27 Mar 2020 17:53:39 +0100 David Hildenbrand wrote: > On 27.03.20 17:46, Igor Mammedov wrote: > > On Fri, 27 Mar 2020 17:05:34 +0100 > > Christian Borntraeger wrote: > > > >> On 27.03.20 17:01, David Hildenbrand wrote: > >>> On 27.03.20 16:34, Christian Borntraeger wrote: >

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread Igor Mammedov
On Fri, 27 Mar 2020 17:51:23 +0100 David Hildenbrand wrote: > On 27.03.20 17:48, Igor Mammedov wrote: > > On Fri, 27 Mar 2020 16:29:30 +0100 > > David Hildenbrand wrote: > > > >> Historically, we fixed up the RAM size (rounded it down), to fit into > >> storage increments. Since commit

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread David Hildenbrand
On 27.03.20 19:16, Halil Pasic wrote: > On Fri, 27 Mar 2020 17:46:20 +0100 > Igor Mammedov wrote: > >> On Fri, 27 Mar 2020 17:05:34 +0100 >> Christian Borntraeger wrote: >> >>> On 27.03.20 17:01, David Hildenbrand wrote: On 27.03.20 16:34, Christian Borntraeger wrote: > > >

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread Halil Pasic
On Fri, 27 Mar 2020 17:46:20 +0100 Igor Mammedov wrote: > On Fri, 27 Mar 2020 17:05:34 +0100 > Christian Borntraeger wrote: > > > On 27.03.20 17:01, David Hildenbrand wrote: > > > On 27.03.20 16:34, Christian Borntraeger wrote: > > >> > > >> > > >> On 27.03.20 16:29, David Hildenbrand wrote:

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread David Hildenbrand
On 27.03.20 17:46, Igor Mammedov wrote: > On Fri, 27 Mar 2020 17:05:34 +0100 > Christian Borntraeger wrote: > >> On 27.03.20 17:01, David Hildenbrand wrote: >>> On 27.03.20 16:34, Christian Borntraeger wrote: On 27.03.20 16:29, David Hildenbrand wrote: > Historically, we

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread David Hildenbrand
On 27.03.20 17:48, Igor Mammedov wrote: > On Fri, 27 Mar 2020 16:29:30 +0100 > David Hildenbrand wrote: > >> Historically, we fixed up the RAM size (rounded it down), to fit into >> storage increments. Since commit 3a12fc61af5c ("390x/s390-virtio-ccw: use >> memdev for RAM"), we no longer

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread Igor Mammedov
On Fri, 27 Mar 2020 16:29:30 +0100 David Hildenbrand wrote: > Historically, we fixed up the RAM size (rounded it down), to fit into > storage increments. Since commit 3a12fc61af5c ("390x/s390-virtio-ccw: use > memdev for RAM"), we no longer consider the fixed-up size when > allcoating the RAM

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread Igor Mammedov
On Fri, 27 Mar 2020 17:05:34 +0100 Christian Borntraeger wrote: > On 27.03.20 17:01, David Hildenbrand wrote: > > On 27.03.20 16:34, Christian Borntraeger wrote: > >> > >> > >> On 27.03.20 16:29, David Hildenbrand wrote: > >>> Historically, we fixed up the RAM size (rounded it down), to fit

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread Christian Borntraeger
On 27.03.20 17:01, David Hildenbrand wrote: > On 27.03.20 16:34, Christian Borntraeger wrote: >> >> >> On 27.03.20 16:29, David Hildenbrand wrote: >>> Historically, we fixed up the RAM size (rounded it down), to fit into >>> storage increments. Since commit 3a12fc61af5c ("390x/s390-virtio-ccw:

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread David Hildenbrand
On 27.03.20 16:34, Christian Borntraeger wrote: > > > On 27.03.20 16:29, David Hildenbrand wrote: >> Historically, we fixed up the RAM size (rounded it down), to fit into >> storage increments. Since commit 3a12fc61af5c ("390x/s390-virtio-ccw: use >> memdev for RAM"), we no longer consider the

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread Christian Borntraeger
On 27.03.20 16:29, David Hildenbrand wrote: > Historically, we fixed up the RAM size (rounded it down), to fit into > storage increments. Since commit 3a12fc61af5c ("390x/s390-virtio-ccw: use > memdev for RAM"), we no longer consider the fixed-up size when > allcoating the RAM block - which

[PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread David Hildenbrand
Historically, we fixed up the RAM size (rounded it down), to fit into storage increments. Since commit 3a12fc61af5c ("390x/s390-virtio-ccw: use memdev for RAM"), we no longer consider the fixed-up size when allcoating the RAM block - which will break migration. Let's simply drop that manual fixup