Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'

2020-09-11 Thread Ani Sinha
On Fri, Sep 11, 2020 at 9:51 PM Ani Sinha wrote: > > I can't repro the breakage. What test command line are you running > with? I am using " make check-qtest-x86_64 V=1" Ok I was working off v5.1.0 tag. Did not realize. I rebased all my patches to the latest master and reworked the unit tests. I

Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'

2020-09-11 Thread Ani Sinha
I can't repro the breakage. What test command line are you running with? I am using " make check-qtest-x86_64 V=1" On Fri, Sep 11, 2020 at 9:41 PM Ani Sinha wrote: > > On Fri, Sep 11, 2020 at 9:38 PM Michael S. Tsirkin wrote: > > > > > > I am not sure why, but the expected files did not match

Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'

2020-09-11 Thread Ani Sinha
On Fri, Sep 11, 2020 at 9:38 PM Michael S. Tsirkin wrote: > > > I am not sure why, but the expected files did not match for me. > > I dropped these for now: > > tests/acpi: add a new ACPI table in order to test root pci hotplug on/off > tests/acpi: add a new unit test to test hotplug off/on

Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'

2020-09-11 Thread Michael S. Tsirkin
I am not sure why, but the expected files did not match for me. I dropped these for now: tests/acpi: add a new ACPI table in order to test root pci hotplug on/off tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus tests/acpi: document addition of table

Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'

2020-09-05 Thread Ani Sinha
On Sat, Sep 5, 2020 at 4:05 PM Ani Sinha wrote: > > The following patchset adds the unit test for the change: > f80ba9e599 ("tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' > bridge flag") Apologies. This change is incorrect. It should be : e78c1c9a2e ("i440fx/acpi: do not add

[PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'

2020-09-05 Thread Ani Sinha
The following patchset adds the unit test for the change: f80ba9e599 ("tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag") Please compare the diff of the DSDT table attached with the commit log with the following diff which was generated before appplying the above