Re: [PATCH v1 06/14] tests/vm: Add logging of console to file.

2020-02-10 Thread Robert Foley
On Fri, 7 Feb 2020 at 17:20, Robert Foley wrote: > > On Fri, 7 Feb 2020 at 12:12, Alex Bennée wrote: > > > + > > > +def join(self, timeout=None): > > > +"""Time to destroy the thread. > > > + Clear the event to stop the thread, and wait for > > > + it to

Re: [PATCH v1 06/14] tests/vm: Add logging of console to file.

2020-02-07 Thread Robert Foley
On Fri, 7 Feb 2020 at 12:12, Alex Bennée wrote: > Robert Foley writes: > > > This adds logging of the char device used by the console > > to a file. The basevm.py then uses this file to read > > chars from the console. > > One reason to add this is to aid with debugging. > > I can certainly see

Re: [PATCH v1 06/14] tests/vm: Add logging of console to file.

2020-02-07 Thread Alex Bennée
Robert Foley writes: > This adds logging of the char device used by the console > to a file. The basevm.py then uses this file to read > chars from the console. > One reason to add this is to aid with debugging. I can certainly see an argument for saving the install log. > But another is

[PATCH v1 06/14] tests/vm: Add logging of console to file.

2020-02-05 Thread Robert Foley
This adds logging of the char device used by the console to a file. The basevm.py then uses this file to read chars from the console. One reason to add this is to aid with debugging. But another is because there is an issue where the QEMU might hang if the characters from the character device are