Re: [PATCH v1 1/1] target/riscv: Print CPU and privledge in disas

2019-09-27 Thread Alistair Francis
On Fri, Sep 27, 2019 at 10:53 AM Richard Henderson wrote: > > On 9/27/19 10:23 AM, Alistair Francis wrote: > >> I'm curious about the motivation here. > >> > >> In particular, what difference does it make what cpu the TB is generated > >> for? > >> It would seem like the more relevant place to

Re: [PATCH v1 1/1] target/riscv: Print CPU and privledge in disas

2019-09-27 Thread Richard Henderson
On 9/26/19 5:45 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > target/riscv/translate.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/target/riscv/translate.c b/target/riscv/translate.c > index adeddb85f6..537af0003e 100644 > ---

Re: [PATCH v1 1/1] target/riscv: Print CPU and privledge in disas

2019-09-27 Thread Richard Henderson
On 9/27/19 10:23 AM, Alistair Francis wrote: >> I'm curious about the motivation here. >> >> In particular, what difference does it make what cpu the TB is generated for? >> It would seem like the more relevant place to look for this is with -d cpu or >> -d exec where the TB is actually executed,

Re: [PATCH v1 1/1] target/riscv: Print CPU and privledge in disas

2019-09-27 Thread Alistair Francis
On Fri, Sep 27, 2019 at 2:10 AM Philippe Mathieu-Daudé wrote: > > On 9/27/19 2:45 AM, Alistair Francis wrote: > > Signed-off-by: Alistair Francis > > --- > > target/riscv/translate.c | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/target/riscv/translate.c

Re: [PATCH v1 1/1] target/riscv: Print CPU and privledge in disas

2019-09-27 Thread Alistair Francis
On Fri, Sep 27, 2019 at 10:18 AM Richard Henderson wrote: > > On 9/26/19 5:45 PM, Alistair Francis wrote: > > Signed-off-by: Alistair Francis > > --- > > target/riscv/translate.c | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/target/riscv/translate.c

Re: [PATCH v1 1/1] target/riscv: Print CPU and privledge in disas

2019-09-27 Thread Philippe Mathieu-Daudé
On 9/27/19 2:45 AM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > target/riscv/translate.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/target/riscv/translate.c b/target/riscv/translate.c > index adeddb85f6..537af0003e 100644 > ---

Re: [PATCH v1 1/1] target/riscv: Print CPU and privledge in disas

2019-09-26 Thread Bin Meng
On Fri, Sep 27, 2019 at 8:55 AM Alistair Francis wrote: typo "privledge" in the commit title > > Signed-off-by: Alistair Francis > --- > target/riscv/translate.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/target/riscv/translate.c b/target/riscv/translate.c > index

[PATCH v1 1/1] target/riscv: Print CPU and privledge in disas

2019-09-26 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/translate.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index adeddb85f6..537af0003e 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -810,7 +810,14 @@