Re: [PATCH v1 12/13] hw/virtio/vhost-user: don't suppress F_CONFIG when supported

2022-03-22 Thread Michael S. Tsirkin
On Tue, Mar 22, 2022 at 03:54:32PM +, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Mon, Mar 21, 2022 at 03:30:36PM +, Alex Bennée wrote: > >> Previously we would silently suppress VHOST_USER_PROTOCOL_F_CONFIG > >> during the protocol negotiation if the QEMU stub hadn't

Re: [PATCH v1 12/13] hw/virtio/vhost-user: don't suppress F_CONFIG when supported

2022-03-22 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Mon, Mar 21, 2022 at 03:30:36PM +, Alex Bennée wrote: >> Previously we would silently suppress VHOST_USER_PROTOCOL_F_CONFIG >> during the protocol negotiation if the QEMU stub hadn't implemented >> the vhost_dev_config_notifier. However this isn't the only

Re: [PATCH v1 12/13] hw/virtio/vhost-user: don't suppress F_CONFIG when supported

2022-03-22 Thread Michael S. Tsirkin
On Mon, Mar 21, 2022 at 03:30:36PM +, Alex Bennée wrote: > Previously we would silently suppress VHOST_USER_PROTOCOL_F_CONFIG > during the protocol negotiation if the QEMU stub hadn't implemented > the vhost_dev_config_notifier. However this isn't the only way we can > handle config messages,

[PATCH v1 12/13] hw/virtio/vhost-user: don't suppress F_CONFIG when supported

2022-03-21 Thread Alex Bennée
Previously we would silently suppress VHOST_USER_PROTOCOL_F_CONFIG during the protocol negotiation if the QEMU stub hadn't implemented the vhost_dev_config_notifier. However this isn't the only way we can handle config messages, the existing vdc->get/set_config can do this as well. Lightly