Re: [PATCH v14 04/10] accel/tcg: add jit stats and time to TBStatistics

2023-06-01 Thread Richard Henderson
On 5/31/23 23:48, Wu, Fei wrote: On 6/1/2023 9:08 AM, Richard Henderson wrote: On 5/30/23 01:35, Fei Wu wrote: +    qatomic_add(_ctx->prof.cpu_exec_time, profile_getclock() - ti); You can't qatomic_add a 64-bit value on a 32-bit host. Right, I only changed the counters to size_t, didn't

Re: [PATCH v14 04/10] accel/tcg: add jit stats and time to TBStatistics

2023-06-01 Thread Richard Henderson
On 5/31/23 23:48, Wu, Fei wrote: -int64_t tcg_cpu_exec_time(void); +uint64_t tcg_cpu_exec_time(void); Why?  (Also, probably wants removing, per above.) The original patch mentioned 'make it an uint64_t as we won't be dealing in negative numbers.' The signed vs unsigned thing is something

Re: [PATCH v14 04/10] accel/tcg: add jit stats and time to TBStatistics

2023-06-01 Thread Wu, Fei
On 6/1/2023 9:08 AM, Richard Henderson wrote: > On 5/30/23 01:35, Fei Wu wrote: >> +static void collect_jit_profile_info(void *p, uint32_t hash, void >> *userp) >> +{ >> +    struct jit_profile_info *jpi = userp; >> +    TBStatistics *tbs = p; >> + >> +    jpi->translations +=

Re: [PATCH v14 04/10] accel/tcg: add jit stats and time to TBStatistics

2023-05-31 Thread Richard Henderson
On 5/30/23 01:35, Fei Wu wrote: +static void collect_jit_profile_info(void *p, uint32_t hash, void *userp) +{ +struct jit_profile_info *jpi = userp; +TBStatistics *tbs = p; + +jpi->translations += tbs->translations.total; +jpi->ops += tbs->code.num_tcg_ops; +if

Re: [PATCH v14 04/10] accel/tcg: add jit stats and time to TBStatistics

2023-05-30 Thread Wu, Fei
On 5/30/2023 5:37 PM, Markus Armbruster wrote: > Fei Wu writes: > >> This collects all the statistics for TBStatistics, not only for the >> whole emulation but for each TB. >> >> Signed-off-by: Vanderson M. do Rosario >> Signed-off-by: Alex Bennée >> Signed-off-by: Fei Wu >> --- >>

Re: [PATCH v14 04/10] accel/tcg: add jit stats and time to TBStatistics

2023-05-30 Thread Markus Armbruster
Fei Wu writes: > This collects all the statistics for TBStatistics, not only for the > whole emulation but for each TB. > > Signed-off-by: Vanderson M. do Rosario > Signed-off-by: Alex Bennée > Signed-off-by: Fei Wu > --- > accel/tcg/monitor.c | 20 - > accel/tcg/tb-stats.c

[PATCH v14 04/10] accel/tcg: add jit stats and time to TBStatistics

2023-05-30 Thread Fei Wu
This collects all the statistics for TBStatistics, not only for the whole emulation but for each TB. Signed-off-by: Vanderson M. do Rosario Signed-off-by: Alex Bennée Signed-off-by: Fei Wu --- accel/tcg/monitor.c | 20 - accel/tcg/tb-stats.c | 146