Re: [PATCH v16 21/23] accel: introduce new accessor functions

2021-02-14 Thread Claudio Fontana
On 2/8/21 1:54 PM, Philippe Mathieu-Daudé wrote: > On 2/8/21 1:50 PM, Claudio Fontana wrote: >> On 2/5/21 9:14 PM, Richard Henderson wrote: >>> On 2/4/21 6:39 AM, Claudio Fontana wrote: @@ -6725,10 +6722,8 @@ static void x86_cpu_initfn(Object *obj) x86_cpu_load_model(cpu,

Re: [PATCH v16 21/23] accel: introduce new accessor functions

2021-02-10 Thread Claudio Fontana
On 2/8/21 1:54 PM, Philippe Mathieu-Daudé wrote: > On 2/8/21 1:50 PM, Claudio Fontana wrote: >> On 2/5/21 9:14 PM, Richard Henderson wrote: >>> On 2/4/21 6:39 AM, Claudio Fontana wrote: @@ -6725,10 +6722,8 @@ static void x86_cpu_initfn(Object *obj) x86_cpu_load_model(cpu,

Re: [PATCH v16 21/23] accel: introduce new accessor functions

2021-02-08 Thread Philippe Mathieu-Daudé
On 2/8/21 1:50 PM, Claudio Fontana wrote: > On 2/5/21 9:14 PM, Richard Henderson wrote: >> On 2/4/21 6:39 AM, Claudio Fontana wrote: >>> @@ -6725,10 +6722,8 @@ static void x86_cpu_initfn(Object *obj) >>> x86_cpu_load_model(cpu, xcc->model); >>> } >>> >>> -/* if required, do the

Re: [PATCH v16 21/23] accel: introduce new accessor functions

2021-02-08 Thread Claudio Fontana
On 2/5/21 9:14 PM, Richard Henderson wrote: > On 2/4/21 6:39 AM, Claudio Fontana wrote: >> @@ -6725,10 +6722,8 @@ static void x86_cpu_initfn(Object *obj) >> x86_cpu_load_model(cpu, xcc->model); >> } >> >> -/* if required, do the accelerator-specific cpu initialization */ >> -

Re: [PATCH v16 21/23] accel: introduce new accessor functions

2021-02-05 Thread Richard Henderson
On 2/4/21 6:39 AM, Claudio Fontana wrote: > @@ -6725,10 +6722,8 @@ static void x86_cpu_initfn(Object *obj) > x86_cpu_load_model(cpu, xcc->model); > } > > -/* if required, do the accelerator-specific cpu initialization */ > -if (cc->accel_cpu) { > -

[PATCH v16 21/23] accel: introduce new accessor functions

2021-02-04 Thread Claudio Fontana
avoid open coding the accesses to cpu->accel_cpu interfaces, and instead introduce: accel_cpu_instance_init, accel_cpu_realizefn to be used by the targets/ initfn code, and by cpu_exec_realizefn respectively. Signed-off-by: Claudio Fontana --- include/qemu/accel.h | 13 +