Re: [PATCH v16 23/23] accel-cpu: make cpu_realizefn return a bool

2021-02-05 Thread Richard Henderson
On 2/4/21 6:39 AM, Claudio Fontana wrote: > overall, all devices' realize functions take an Error **errp, but return void. > > hw/core/qdev.c code, which realizes devices, therefore does: > > local_err = NULL; > dc->realize(dev, _err); > if (local_err != NULL) { > goto fail; > } > >

[PATCH v16 23/23] accel-cpu: make cpu_realizefn return a bool

2021-02-04 Thread Claudio Fontana
overall, all devices' realize functions take an Error **errp, but return void. hw/core/qdev.c code, which realizes devices, therefore does: local_err = NULL; dc->realize(dev, _err); if (local_err != NULL) { goto fail; } However, we can improve at least accel_cpu to return a meaningful bool