Re: [PATCH v2] Report stringified errno in VFIO related errors

2020-02-14 Thread Laurent Vivier
Le 14/02/2020 à 16:35, Alex Williamson a écrit : > On Fri, 14 Feb 2020 10:55:19 +0100 > Michal Privoznik wrote: > >> In a few places we report errno formatted as a negative integer. >> This is not as user friendly as it can be. Use strerror() and/or >> error_setg_errno() instead. >> >> Signed-off

Re: [PATCH v2] Report stringified errno in VFIO related errors

2020-02-14 Thread Alex Williamson
On Fri, 14 Feb 2020 10:55:19 +0100 Michal Privoznik wrote: > In a few places we report errno formatted as a negative integer. > This is not as user friendly as it can be. Use strerror() and/or > error_setg_errno() instead. > > Signed-off-by: Michal Privoznik > --- > > v1 posted here: > > http

Re: [PATCH v2] Report stringified errno in VFIO related errors

2020-02-14 Thread Philippe Mathieu-Daudé
On Fri, Feb 14, 2020 at 10:56 AM Michal Privoznik wrote: > > In a few places we report errno formatted as a negative integer. > This is not as user friendly as it can be. Use strerror() and/or > error_setg_errno() instead. > > Signed-off-by: Michal Privoznik > --- Reviewed-by: Philippe Mathieu-D

Re: [PATCH v2] Report stringified errno in VFIO related errors

2020-02-14 Thread Auger Eric
Hi Michal, On 2/14/20 10:55 AM, Michal Privoznik wrote: > In a few places we report errno formatted as a negative integer. > This is not as user friendly as it can be. Use strerror() and/or > error_setg_errno() instead. > > Signed-off-by: Michal Privoznik Reviewed-by: Eric Auger Thanks Eric >

Re: [PATCH v2] Report stringified errno in VFIO related errors

2020-02-14 Thread Cornelia Huck
On Fri, 14 Feb 2020 10:55:19 +0100 Michal Privoznik wrote: > In a few places we report errno formatted as a negative integer. > This is not as user friendly as it can be. Use strerror() and/or > error_setg_errno() instead. > > Signed-off-by: Michal Privoznik > --- > > v1 posted here: > > http

Re: [PATCH v2] Report stringified errno in VFIO related errors

2020-02-14 Thread Ján Tomko
On Fri, Feb 14, 2020 at 10:55:19AM +0100, Michal Privoznik wrote: In a few places we report errno formatted as a negative integer. This is not as user friendly as it can be. Use strerror() and/or error_setg_errno() instead. Signed-off-by: Michal Privoznik --- v1 posted here: https://lists.non

[PATCH v2] Report stringified errno in VFIO related errors

2020-02-14 Thread Michal Privoznik
In a few places we report errno formatted as a negative integer. This is not as user friendly as it can be. Use strerror() and/or error_setg_errno() instead. Signed-off-by: Michal Privoznik --- v1 posted here: https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg03623.html diff to v1: