Re: [PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-29 Thread Igor Mammedov
On Wed, 23 Dec 2020 23:56:30 +0200 Marian Posteuca wrote: > Thanks for the thorough review. > > Igor Mammedov writes: > > On Tue, 22 Dec 2020 13:33:53 +0200 > > Marian Posteuca wrote: > > > > I see defaults are now initialized in pcmc->oem_[table_]id fields, > > and sometimes used from there,

Re: [PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-27 Thread Marian Posteuca
Paolo Bonzini writes: > On 22/12/20 16:39, Marian Posteuca wrote: Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPC" where "" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI

Re: [PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-23 Thread Marian Posteuca
Thanks for the thorough review. Igor Mammedov writes: > On Tue, 22 Dec 2020 13:33:53 +0200 > Marian Posteuca wrote: > > I see defaults are now initialized in pcmc->oem_[table_]id fields, > and sometimes used from there, so question is why > do we need use_sig_oem and keeping old code > >

Re: [PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-23 Thread Igor Mammedov
On Tue, 22 Dec 2020 13:33:53 +0200 Marian Posteuca wrote: > Qemu's ACPI table generation sets the fields OEM ID and OEM table ID > to "BOCHS " and "BXPC" where "" is replaced by the ACPI > table name. > > Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID > and OEM

Re: [PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-22 Thread Paolo Bonzini
On 22/12/20 16:39, Marian Posteuca wrote: Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPC" where "" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID and OEM table ID for the strings "BOCHS"

Re: [PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-22 Thread Marian Posteuca
Michael Tokarev writes: > 22.12.2020 14:33, Marian Posteuca wrote: >> Qemu's ACPI table generation sets the fields OEM ID and OEM table ID >> to "BOCHS " and "BXPC" where "" is replaced by the ACPI >> table name. >> >> Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID

Re: [PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-22 Thread Michael Tokarev
22.12.2020 14:33, Marian Posteuca wrote: Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPC" where "" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID and OEM table ID for the strings "BOCHS"

[PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-22 Thread Marian Posteuca
Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPC" where "" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID and OEM table ID for the strings "BOCHS" and "BXPC" and if they are found, the game