Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-30 Thread Emanuele Giuseppe Esposito
Am 29/03/2022 um 14:15 schrieb Hanna Reitz: > On 29.03.22 11:55, Vladimir Sementsov-Ogievskiy wrote: >> 29.03.2022 11:54, Hanna Reitz wrote: >>> On 28.03.22 12:24, Vladimir Sementsov-Ogievskiy wrote: 28.03.2022 11:09, Hanna Reitz wrote: > On 28.03.22 09:44, Hanna Reitz wrote: >> On

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-29 Thread Hanna Reitz
On 29.03.22 11:55, Vladimir Sementsov-Ogievskiy wrote: 29.03.2022 11:54, Hanna Reitz wrote: On 28.03.22 12:24, Vladimir Sementsov-Ogievskiy wrote: 28.03.2022 11:09, Hanna Reitz wrote: On 28.03.22 09:44, Hanna Reitz wrote: On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote: 24.03.2022

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2022 11:54, Hanna Reitz wrote: On 28.03.22 12:24, Vladimir Sementsov-Ogievskiy wrote: 28.03.2022 11:09, Hanna Reitz wrote: On 28.03.22 09:44, Hanna Reitz wrote: On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote: 24.03.2022 17:09, Hanna Reitz wrote: When the stream block job cuts

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-29 Thread Hanna Reitz
On 28.03.22 12:24, Vladimir Sementsov-Ogievskiy wrote: 28.03.2022 11:09, Hanna Reitz wrote: On 28.03.22 09:44, Hanna Reitz wrote: On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote: 24.03.2022 17:09, Hanna Reitz wrote: When the stream block job cuts out the nodes between top and base in

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-28 Thread Vladimir Sementsov-Ogievskiy
28.03.2022 11:09, Hanna Reitz wrote: On 28.03.22 09:44, Hanna Reitz wrote: On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote: 24.03.2022 17:09, Hanna Reitz wrote: When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually;

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-28 Thread Hanna Reitz
On 28.03.22 09:44, Hanna Reitz wrote: On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote: 24.03.2022 17:09, Hanna Reitz wrote: When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually; it fetches the base node, and tries

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-28 Thread Hanna Reitz
On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote: 24.03.2022 17:09, Hanna Reitz wrote: When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually; it fetches the base node, and tries to insert it as the top node's backing

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-25 Thread Vladimir Sementsov-Ogievskiy
24.03.2022 17:09, Hanna Reitz wrote: When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually; it fetches the base node, and tries to insert it as the top node's backing node with bdrv_set_backing_hd(). bdrv_set_backing_hd()

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-25 Thread Eric Blake
On Thu, Mar 24, 2022 at 03:09:07PM +0100, Hanna Reitz wrote: > When the stream block job cuts out the nodes between top and base in > stream_prepare(), it does not drain the subtree manually; it fetches the > base node, and tries to insert it as the top node's backing node with >

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-25 Thread Hanna Reitz
On 24.03.22 19:49, John Snow wrote: On Thu, Mar 24, 2022 at 10:09 AM Hanna Reitz wrote: When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually; it fetches the base node, and tries to insert it as the top node's backing node

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-24 Thread John Snow
On Thu, Mar 24, 2022 at 10:09 AM Hanna Reitz wrote: > > When the stream block job cuts out the nodes between top and base in > stream_prepare(), it does not drain the subtree manually; it fetches the > base node, and tries to insert it as the top node's backing node with > bdrv_set_backing_hd().

[PATCH v2] block/stream: Drain subtree around graph change

2022-03-24 Thread Hanna Reitz
When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually; it fetches the base node, and tries to insert it as the top node's backing node with bdrv_set_backing_hd(). bdrv_set_backing_hd() however will drain, and so the actual