Re: [PATCH v2] hw/audio/pcspk: Inline pcspk_init()

On 20/10/23 06:49, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 19/10/23 19:54, Markus Armbruster wrote: Bernhard Beschow writes: Am 19. Oktober 2023 07:33:07 UTC schrieb "Philippe Mathieu-Daudé" : pcspk_init() is a legacy init function, inline and remove it. Since the dev

Re: [PATCH v2] hw/audio/pcspk: Inline pcspk_init()

Philippe Mathieu-Daudé writes: > On 19/10/23 19:54, Markus Armbruster wrote: >> Bernhard Beschow writes: >> >>> Am 19. Oktober 2023 07:33:07 UTC schrieb "Philippe Mathieu-Daudé" >>> : pcspk_init() is a legacy init function, inline and remove it. Since the device is realized usin

Re: [PATCH v2] hw/audio/pcspk: Inline pcspk_init()

On 19/10/23 19:54, Markus Armbruster wrote: Bernhard Beschow writes: Am 19. Oktober 2023 07:33:07 UTC schrieb "Philippe Mathieu-Daudé" : pcspk_init() is a legacy init function, inline and remove it. Since the device is realized using &error_fatal, use the same error for setting the "pit" li

Re: [PATCH v2] hw/audio/pcspk: Inline pcspk_init()

Bernhard Beschow writes: > Am 19. Oktober 2023 07:33:07 UTC schrieb "Philippe Mathieu-Daudé" > : >>pcspk_init() is a legacy init function, inline and remove it. >> >>Since the device is realized using &error_fatal, use the same >>error for setting the "pit" link. >> >>Reviewed-by: Mark Cave-Ayla

Re: [PATCH v2] hw/audio/pcspk: Inline pcspk_init()

Am 19. Oktober 2023 07:33:07 UTC schrieb "Philippe Mathieu-Daudé" : >pcspk_init() is a legacy init function, inline and remove it. > >Since the device is realized using &error_fatal, use the same >error for setting the "pit" link. > >Reviewed-by: Mark Cave-Ayland >Signed-off-by: Philippe Mathi

[PATCH v2] hw/audio/pcspk: Inline pcspk_init()

pcspk_init() is a legacy init function, inline and remove it. Since the device is realized using &error_fatal, use the same error for setting the "pit" link. Reviewed-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daudé --- include/hw/audio/pcspk.h | 10 -- hw/i386/pc.c