Re: [PATCH v2] hw/display/tcx: Mark the VRAM dirty upon reset

2022-09-25 Thread Philippe Mathieu-Daudé via
On Sun, Feb 6, 2022 at 11:44 AM Peter Maydell wrote: > > On Sun, 6 Feb 2022 at 09:30, Mark Cave-Ayland > wrote: > > > > On 05/02/2022 15:39, Peter Maydell wrote: > > > The handling of the vram buffer seems weird in this device overall, > > > though -- the memory block is divided into three parts

Re: [PATCH v2] hw/display/tcx: Mark the VRAM dirty upon reset

2022-02-06 Thread Peter Maydell
On Sun, 6 Feb 2022 at 09:30, Mark Cave-Ayland wrote: > > On 05/02/2022 15:39, Peter Maydell wrote: > > The handling of the vram buffer seems weird in this device overall, > > though -- the memory block is divided into three parts > > * main vram, one byte per pixel > > * vram24, four bytes

Re: [PATCH v2] hw/display/tcx: Mark the VRAM dirty upon reset

2022-02-06 Thread Mark Cave-Ayland
On 05/02/2022 15:39, Peter Maydell wrote: On Sat, 5 Feb 2022 at 14:24, BALATON Zoltan wrote: On Sat, 5 Feb 2022, Mark Cave-Ayland wrote: On 03/02/2022 00:05, Philippe Mathieu-Daudé via wrote: When resetting we don't want to *reset* the dirty bitmap, we want to *set* it to mark the entire

Re: [PATCH v2] hw/display/tcx: Mark the VRAM dirty upon reset

2022-02-05 Thread Peter Maydell
On Sat, 5 Feb 2022 at 14:24, BALATON Zoltan wrote: > > On Sat, 5 Feb 2022, Mark Cave-Ayland wrote: > > On 03/02/2022 00:05, Philippe Mathieu-Daudé via wrote: > > > >> When resetting we don't want to *reset* the dirty bitmap, > >> we want to *set* it to mark the entire VRAM dirty due to > >> the

Re: [PATCH v2] hw/display/tcx: Mark the VRAM dirty upon reset

2022-02-05 Thread BALATON Zoltan
On Sat, 5 Feb 2022, Mark Cave-Ayland wrote: On 03/02/2022 00:05, Philippe Mathieu-Daudé via wrote: When resetting we don't want to *reset* the dirty bitmap, we want to *set* it to mark the entire VRAM dirty due to the memset() call. Replace memory_region_reset_dirty() by tcx_set_dirty() which

Re: [PATCH v2] hw/display/tcx: Mark the VRAM dirty upon reset

2022-02-05 Thread Mark Cave-Ayland
On 03/02/2022 00:05, Philippe Mathieu-Daudé via wrote: When resetting we don't want to *reset* the dirty bitmap, we want to *set* it to mark the entire VRAM dirty due to the memset() call. Replace memory_region_reset_dirty() by tcx_set_dirty() which conveniently set the correct ranges dirty.

[PATCH v2] hw/display/tcx: Mark the VRAM dirty upon reset

2022-02-02 Thread Philippe Mathieu-Daudé via
When resetting we don't want to *reset* the dirty bitmap, we want to *set* it to mark the entire VRAM dirty due to the memset() call. Replace memory_region_reset_dirty() by tcx_set_dirty() which conveniently set the correct ranges dirty. Suggested-by: Mark Cave-Ayland Signed-off-by: Philippe