Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

2023-10-03 Thread Michael S. Tsirkin
On Tue, Oct 03, 2023 at 11:13:06AM +0530, Ani Sinha wrote: > Code changes that addresses all compiler complaints coming from enabling > -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing > other local variables or parameters. These makes the code confusing and/or > adds

Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

2023-10-03 Thread Ani Sinha
> On 03-Oct-2023, at 11:13 AM, Ani Sinha wrote: > > Code changes that addresses all compiler complaints coming from enabling > -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing > other local variables or parameters. These makes the code confusing and/or > adds >

Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

2023-10-02 Thread Ani Sinha
On Mon, Oct 2, 2023 at 4:17 PM Michael S. Tsirkin wrote: > > On Thu, Sep 28, 2023 at 09:14:07AM +0530, Ani Sinha wrote: > > > > > > > On 27-Sep-2023, at 8:55 PM, Michael S. Tsirkin wrote: > > > > > > On Tue, Sep 26, 2023 at 11:22:35AM +0530, Ani Sinha wrote: > > >> Code changes that addresses

[PATCH v2] hw/i386: changes towards enabling -Wshadow=local

2023-10-02 Thread Ani Sinha
Code changes that addresses all compiler complaints coming from enabling -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing other local variables or parameters. These makes the code confusing and/or adds bugs that are difficult to catch. CC: Markus Armbruster CC:

Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

2023-10-02 Thread Michael S. Tsirkin
On Thu, Sep 28, 2023 at 09:14:07AM +0530, Ani Sinha wrote: > > > > On 27-Sep-2023, at 8:55 PM, Michael S. Tsirkin wrote: > > > > On Tue, Sep 26, 2023 at 11:22:35AM +0530, Ani Sinha wrote: > >> Code changes that addresses all compiler complaints coming from enabling > >> -Wshadow flags.

Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

2023-09-27 Thread Ani Sinha
> On 27-Sep-2023, at 8:55 PM, Michael S. Tsirkin wrote: > > On Tue, Sep 26, 2023 at 11:22:35AM +0530, Ani Sinha wrote: >> Code changes that addresses all compiler complaints coming from enabling >> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing >> other local

Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

2023-09-27 Thread Michael S. Tsirkin
On Tue, Sep 26, 2023 at 11:22:35AM +0530, Ani Sinha wrote: > Code changes that addresses all compiler complaints coming from enabling > -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing > other local variables or parameters. These makes the code confusing and/or > adds

[PATCH v2] hw/i386: changes towards enabling -Wshadow=local

2023-09-25 Thread Ani Sinha
Code changes that addresses all compiler complaints coming from enabling -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing other local variables or parameters. These makes the code confusing and/or adds bugs that are difficult to catch. CC: Markus Armbruster CC: