RE: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-12 Thread Chenqun (kuhn)
>Subject: Re: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in >imx_enet_write() > >On Tue, 10 Mar 2020 at 08:08, Chenqun (kuhn) >wrote: >> >> >-Original Message- >> >From: Peter Maydell [mailto:peter.mayd...@linaro.org] >> >> >> &g

Re: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-12 Thread Peter Maydell
On Tue, 10 Mar 2020 at 08:08, Chenqun (kuhn) wrote: > > >-Original Message- > >From: Peter Maydell [mailto:peter.mayd...@linaro.org] > >> > >> diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index > >> 6a124a154a..322cbdcc17 100644 > >> --- a/hw/net/imx_fec.c > >> +++ b/hw/net/imx_fec.c

RE: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-10 Thread Chenqun (kuhn)
>Subject: Re: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in >imx_enet_write() > >On Thu, 5 Mar 2020 at 10:53, Chen Qun wrote: >> >> The current code causes clang static code analyzer generate warning: >> hw/net/imx_fec.c:858:9: warning: Value stored to 'v

Re: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-09 Thread Peter Maydell
On Thu, 5 Mar 2020 at 10:53, Chen Qun wrote: > > The current code causes clang static code analyzer generate warning: > hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read > value = value & 0x000f; > ^ ~~ > hw/net/imx_fec.c:864:9:

Re: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200305105325.31264-1-kuhn.chen...@huawei.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200305105325.31264-1-kuhn.chen...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

RE: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-05 Thread Chenqun (kuhn)
;; Euler Robot >Subject: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in >imx_enet_write() > >The current code causes clang static code analyzer generate warning: >hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read >value = value & 0x000

[PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-05 Thread Chen Qun
The current code causes clang static code analyzer generate warning: hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read value = value & 0x000f; ^ ~~ hw/net/imx_fec.c:864:9: warning: Value stored to 'value' is never read value =