Re: Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2022 at 11:53:22AM +0800, ho...@yusur.tech wrote: > On Thu, 22 Sep 2022 09:34:41 +0800 Jason Wang wrote: > > > >On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz > > wrote: > >> > >> If I read your response on the other thread correctly, this change is >

Re: Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2022 at 12:05:40PM +0800, Jason Wang wrote: > On Fri, Sep 23, 2022 at 11:55 AM ho...@yusur.tech wrote: > > > > On Thu, 22 Sep 2022 09:34:41 +0800 Jason Wang wrote: > > > > > > >On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz > > > wrote: > > >> > > >> If I read your response on

Re: Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread Jason Wang
On Fri, Sep 23, 2022 at 11:55 AM ho...@yusur.tech wrote: > > On Thu, 22 Sep 2022 09:34:41 +0800 Jason Wang wrote: > > > >On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz > > wrote: > >> > >> If I read your response on the other thread correctly, this change is > >> intended > >> > >> to

Re: Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread ho...@yusur.tech
On Thu, 22 Sep 2022 09:34:41 +0800 Jason Wang wrote: >On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz > wrote: >> >> If I read your response on the other thread correctly, this change is >> intended >> >> to prioritize the MAC address exposed by DPDK over the one provided by the >> >> QEMU

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread 陈浩
On 2022/9/22 18:19, Michael S. Tsirkin wrote: On Thu, Sep 22, 2022 at 11:02:56AM +0100, Alex Bennée wrote: "Michael S. Tsirkin" writes: On Wed, Sep 21, 2022 at 07:23:12PM +0100, Alex Bennée wrote: chenh writes: From: Hao Chen When use dpdk-vdpa tests vdpa device. You need to specify

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread Jason Wang
On Fri, Sep 23, 2022 at 11:33 AM 陈浩 wrote: > > > On 2022/9/22 17:56, Michael S. Tsirkin wrote: > > On Thu, Sep 22, 2022 at 09:34:41AM +0800, Jason Wang wrote: > >> On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz > >> wrote: > >>> If I read your response on the other thread correctly, this change

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread 陈浩
On 2022/9/22 17:56, Michael S. Tsirkin wrote: On Thu, Sep 22, 2022 at 09:34:41AM +0800, Jason Wang wrote: On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz wrote: If I read your response on the other thread correctly, this change is intended to prioritize the MAC address exposed by DPDK over

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 09:34:41AM +0800, Jason Wang wrote: > On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz > wrote: > > > > If I read your response on the other thread correctly, this change is > > intended > > > > to prioritize the MAC address exposed by DPDK over the one provided by the > >

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 11:02:56AM +0100, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Wed, Sep 21, 2022 at 07:23:12PM +0100, Alex Bennée wrote: > >> > >> chenh writes: > >> > >> > From: Hao Chen > >> > > >> > When use dpdk-vdpa tests vdpa device. You need to specify the mac

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Wed, Sep 21, 2022 at 07:23:12PM +0100, Alex Bennée wrote: >> >> chenh writes: >> >> > From: Hao Chen >> > >> > When use dpdk-vdpa tests vdpa device. You need to specify the mac address >> > to >> > start the virtual machine through libvirt or qemu, but

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-21 Thread Jason Wang
On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz wrote: > > If I read your response on the other thread correctly, this change is intended > > to prioritize the MAC address exposed by DPDK over the one provided by the > > QEMU command line? Sounds reasonable in principle, but I would get >

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-21 Thread Michael S. Tsirkin
On Wed, Sep 21, 2022 at 07:23:12PM +0100, Alex Bennée wrote: > > chenh writes: > > > From: Hao Chen > > > > When use dpdk-vdpa tests vdpa device. You need to specify the mac address to > > start the virtual machine through libvirt or qemu, but now, the libvirt or > > qemu can call dpdk vdpa

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-21 Thread Alex Bennée
chenh writes: > From: Hao Chen > > When use dpdk-vdpa tests vdpa device. You need to specify the mac address to > start the virtual machine through libvirt or qemu, but now, the libvirt or > qemu can call dpdk vdpa vendor driver's ops .get_config through > vhost_net_get_config > to get the

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-21 Thread Raphael Norwitz
If I read your response on the other thread correctly, this change is intended to prioritize the MAC address exposed by DPDK over the one provided by the QEMU command line? Sounds reasonable in principle, but I would get confirmation from vDPA/vhost-net maintainers. That said the way you’re

[PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-21 Thread chenh
From: Hao Chen When use dpdk-vdpa tests vdpa device. You need to specify the mac address to start the virtual machine through libvirt or qemu, but now, the libvirt or qemu can call dpdk vdpa vendor driver's ops .get_config through vhost_net_get_config to get the mac address of the vdpa hardware