Re: [PATCH v2] net/macos: implement vmnet-based network device

2021-03-15 Thread Markus Armbruster
Phillip Tennen writes: > Markus, thanks for the review. I apologize for my lateness in getting back > to you. > > I've integrated most of your suggestions, and will submit a v5 that > incorporates them. I've left a couple comments and questions for you below. > > Aside: I haven't responded

Re: [PATCH v2] net/macos: implement vmnet-based network device

2021-03-12 Thread Phillip Tennen
Markus, thanks for the review. I apologize for my lateness in getting back to you. I've integrated most of your suggestions, and will submit a v5 that incorporates them. I've left a couple comments and questions for you below. Aside: I haven't responded inline to emails like this before, I'm

Re: [PATCH v2] net/macos: implement vmnet-based network device

2021-03-02 Thread Markus Armbruster
Phillip, this doesn't apply anymore. I'm reviewing the QAPI schema part anyway. Peter, there is a question for you below. Search for "Sphinx". phillip.en...@gmail.com writes: > From: Phillip Tennen > > This patch implements a new netdev device, reachable via -netdev > vmnet-macos, that’s

Re: [PATCH v2] net/macos: implement vmnet-based network device

2021-02-11 Thread Phillip Tennen
Hi Howard, Thanks very much for taking a look and testing it out! This is a good catch - VMNET_SHARING_SERVICE_BUSY was added in macOS Big Sur, and is not available in prior versions. I'll submit a v3 of this patch that adds a compile-guard around this constant (assuming the #available macro

Re: [PATCH v2] net/macos: implement vmnet-based network device

2021-02-10 Thread Howard Spoelstra
On Fri, Feb 5, 2021 at 5:54 PM wrote: > > From: Phillip Tennen > > This patch implements a new netdev device, reachable via -netdev > vmnet-macos, that’s backed by macOS’s vmnet framework. > > The vmnet framework provides native bridging support, and its usage in > this patch is intended as a

[PATCH v2] net/macos: implement vmnet-based network device

2021-02-05 Thread phillip . ennen
From: Phillip Tennen This patch implements a new netdev device, reachable via -netdev vmnet-macos, that’s backed by macOS’s vmnet framework. The vmnet framework provides native bridging support, and its usage in this patch is intended as a replacement for attempts to use a tap device via the