Re: [PATCH v2] qom: simplify object_find_property / object_class_find_property

2020-09-18 Thread Eduardo Habkost
On Mon, Sep 14, 2020 at 02:56:17PM +0100, Daniel P. Berrangé wrote: > When debugging QEMU it is often useful to put a breakpoint on the > error_setg_internal method impl. > > Unfortunately the object_property_add / object_class_property_add > methods call object_property_find /

Re: [PATCH v2] qom: simplify object_find_property / object_class_find_property

2020-09-15 Thread Markus Armbruster
Daniel P. Berrangé writes: > When debugging QEMU it is often useful to put a breakpoint on the > error_setg_internal method impl. > > Unfortunately the object_property_add / object_class_property_add > methods call object_property_find / object_class_property_find methods > to check if a

Re: [PATCH v2] qom: simplify object_find_property / object_class_find_property

2020-09-14 Thread Philippe Mathieu-Daudé
On 9/14/20 3:56 PM, Daniel P. Berrangé wrote: > When debugging QEMU it is often useful to put a breakpoint on the > error_setg_internal method impl. > > Unfortunately the object_property_add / object_class_property_add > methods call object_property_find / object_class_property_find methods > to

[PATCH v2] qom: simplify object_find_property / object_class_find_property

2020-09-14 Thread Daniel P . Berrangé
When debugging QEMU it is often useful to put a breakpoint on the error_setg_internal method impl. Unfortunately the object_property_add / object_class_property_add methods call object_property_find / object_class_property_find methods to check if a property exists already before adding the new