[PATCH v2] ui/cocoa: Comment about modifier key input quirks

2021-03-12 Thread Akihiko Odaki
Based-on: <20210310042348.21931-1-akihiko.od...@gmail.com> Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 035f96aab04..35fdc92a51f 100644 --- a/ui/cocoa.m +++ b/ui

Re: [PATCH v2] ui/cocoa: Comment about modifier key input quirks

2021-03-12 Thread Gerd Hoffmann
On Fri, Mar 12, 2021 at 12:12:03AM +0900, Akihiko Odaki wrote: > Based-on: <20210310042348.21931-1-akihiko.od...@gmail.com> > Signed-off-by: Akihiko Odaki Well, the comments should not describe what the code is doing, that is usually pretty clear from reading the code. The comment should say *wh

[PATCH v2] ui/cocoa: Comment about modifier key input quirks

2021-03-11 Thread Akihiko Odaki
Based-on: <20210310042348.21931-1-akihiko.od...@gmail.com> Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 035f96aab04..3d292269c11 100644 --- a/ui/cocoa.m +++ b/ui/cocoa